Skip to content

Avoid text-file-busy failures in the generated webhook fixture #5331

Closed

Description

@devantler

🤖 Generated by the Agentic Engineer

Problem and impact

The parallel Go helper suite can fail before its mutation-enabled webhook fixture starts. This evicts an unrelated candidate from the production merge queue, even though the helper's actual assertions never ran.

Evidence

Platform #5315 was removed with failed_checks at 11:06:33 UTC on 25 October 2026. In the complete-suite job, TestMutationEnabledImageVerificationPolicyRequiresBothWebhooks/missing_mutating_webhook failed with fork/exec .../.refresh-flux-ghcr-auth-test-...: text file busy.

The fixture writes a temporary Bash script, closes it and directly executes that new file while other tests launch processes in parallel. This matches the descriptor inheritance race described in Go issue 22315; closing the parent's writer does not prove another fork has dropped its inherited writer.

Expected outcome

The generated Bash fixture starts reliably under the existing process supervision and still exercises both the refusing and successful webhook paths.

Acceptance criteria

  • Run the generated script through the existing Bash interpreter without directly executing the newly written file.
  • Keep the missing-webhook refusal, both-webhooks success, deadlines and child cleanup checks intact.
  • Both existing mutation-enabled subtests and the complete affected package pass.
  • Record current-head hosted Linux execution before promotion; local macOS success alone does not verify the Linux launch failure.

Size: small. Part of #4979. The later queue failure in run 40187650600 is a separate public-evidence HTTP 403 and is outside this launcher fix.

Activity

  1. added theissue type on Oct 25, 2026
  2. moved this to 📥 Backlog in 🌊 Project Boardon Oct 25, 2026
  3. added a commit that references this issue on Oct 25, 2026
  4. moved this from 📥 Backlog to 🏃🏻‍♂️ In Progress in 🌊 Project Boardon Oct 25, 2026
  5. added 2 commits that reference this issue on Oct 25, 2026
  6. moved this from 🏃🏻‍♂️ In Progress to ✅ Done in 🌊 Project Boardon Oct 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Fields

    Priority

    None yet

    Effort

    None yet

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions