Skip to content

Reject linked desired-state documents in complete package validation #536

Description

@devantler

🤖 Generated by the Agentic Engineer

Problem

The complete package validator can report success while an onboarding desired-state document is linked outside the package and its contents were never fully validated. This lets unusable or non-contained onboarding configuration pass the gate used to ship the marketplace.

At current main 685d06b7398169cfd25245f6f55916538f4f41c5, a complete healthy package passes. Replacing its canonical desired-state file with a link to malformed configuration also passes and emits no desired-state validation result. The identical malformed configuration as a regular packaged file is rejected. The shipped regular document remains healthy.

The existing #379 delivery protects the digest writer. This is the separate package-validator consumer's discovery and containment boundary.

Proposed direction

Observe every desired-state document and resource-directory boundary before reporting package success. Refuse linked or nonregular documents and linked resource parents while retaining supported regular packaged resources.

Acceptance

  • Preserve complete-package RED/GREEN controls for the canonical document, additional documents and linked resource parents, alongside a healthy regular package.
  • Refuse unsupported filesystem boundaries before accepting or silently omitting their contents; incomplete discovery remains a failure.
  • Keep the current marketplace, existing manifest and package-boundary regressions green.
  • Deliver through native current-head CI, substantive review, protected merge and an exercised merged package gate.

Size: S. Part of #436.

Activity

  1. self-assigned this
    on Oct 6, 2026
  2. added theissue type on Oct 6, 2026
  3. added 2 commits that reference this issue on Oct 6, 2026
  4. devantler commented on Oct 6, 2026

    @devantler
    ContributorAuthor

    🤖 Generated by the Agentic Engineer

    Delivered by PR #537, merged at 2026-10-06T05:13:16Z with verified signed main commit 149b300.

    Production-gate RED/GREEN and healthy controls cover 22 complete-entrypoint cases; all 433 existing manifest cases passed. The independently discovered canonical inventory omission was repaired and reviewed. At the evaluated PR head, all 44 successful checks and two expected skips were settled, the required aggregate check was green, substantive current-head review was clean and no findings/threads remained.

    Postmerge user readback: native main run 37417456266, Validate manifests job 112119118941, checked out the exact landed commit and executed the actual complete package command successfully. Its complete log confirms validation of the canonical desired-state document. This observes the real merged package, separately from the refusal fixtures. No remaining delivery blocker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

Fields

Priority

None yet

Effort

None yet

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions