Skip to content

Bind Git suppression checks to actual options #514

Closed

Description

@devantler

🤖 Generated by the Agentic Engineer

Problem and evidence

The read-only command guard counts Git execution-suppression words even when they are path operands. A private synthetic repository demonstrates that the admitted command can run its configured text converter; a genuine suppressed invocation does not.

Expected outcome

Required suppression must be established by actual options before the pathspec boundary. Filename operands cannot prove that Git will suppress external processing.

Acceptance criteria

  • Reproduce the discrepancy using a real Git repository and a harmless converter fixture.
  • Refuse suppression words supplied only as pathspecs.
  • Cover relevant Git read commands and explicit option terminators.
  • Preserve correctly suppressed ordinary read commands.
  • Run guard and installed adapter tests without executing surveyed branch code.

Rough size: S. Part of #223.

Activity

  1. added theissue type on Oct 5, 2026
  2. moved this to 🫴 Ready in 🌊 Project Boardon Oct 5, 2026
  3. self-assigned this
    on Oct 5, 2026
  4. added a commit that references this issue on Oct 5, 2026
  5. devantler commented on Oct 5, 2026

    @devantler
    ContributorAuthor

    🤖 Generated by the Agentic Engineer

    Delivered in merged PR #519 (merge commit 08b218e). The exact reviewed head passed native required CI, the 425 guard regressions, raw JSON observations and surveyor adapter validation. The accompanying repairs now preserve option context and reject malformed original Unicode evidence before identity comparison.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

Fields

Priority

None yet

Effort

None yet

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions