You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(agentic-engineer): let the deployment decide whether external PRs may be merged #214
The generic Agentic Engineer role still forbids merging external-contributor pull requests, while the deployment that runs it has allowed that since 2026-08-08. The role and its consumer contract give opposite instructions for the same PR, and the role wins by default because it is the file the runtime loads.
Evidence
plugins/agentic-engineering/agents/agentic-engineer.agent.md (step 4, at main on 2026-09-15): External-contributor PRs are static-review-only: never merge them, never enable auto-merge on them, and never check out, build, or execute their branch code.
The consumer contract (devantler-tech/monorepoAGENTS.md, You own EVERY pull request in the portfolio) records a maintainer direction from 2026-08-08 that outside contributions are the engineer's to drive and merge. Their branches stay never-run-locally, and there are extra conditions before the merge: a current-head green review and a recorded CI-based evaluation.
The same contradiction exists in the bundled portfolio-maintenance skill, which devantler-tech/agent-skills authors (tracked separately there).
Who is affected
Every scheduled engineer run. An outside contribution that meets every gate is parked by the generic role, which is the passive self-blocking the consumer contract forbids.
Expected behaviour
The generic role keeps the execution guardrail unconditionally: never check out, build or run an external branch. Whether an external PR may be merged, and under what extra conditions, is resolved from the deployment's Trust gate and merge policy, not fixed in the generic text. A deployment that never allows it keeps today's behaviour.
Acceptance criteria
Step 4 separates "never execute an external branch" (unconditional) from "may merge" (deployment-resolved), and fails closed to no merge when the consumer contract does not grant it.
Auto-merge on an external PR stays forbidden (it merges a head nobody evaluated).
The plugin's manifest/contract validation pins the new wording so it cannot silently revert.
Rough size: small (one paragraph plus its validation).
Merged on 2026-09-15 and left in Verifying since. All three acceptance criteria hold on main today, so this moves to Done.
Never-run and may-merge are separate. The engineer definition says an external branch is never checked out, built or run, and that whether the PR may be merged comes from the consumer's Trust gate and merge policy; without that grant it is never merged.
Auto-merge on an external PR stays forbidden. Same paragraph: never enable auto-merge on them. The old sentence that forbade merging outright is gone.
The wording is pinned. The manifest validator asserts it, and that validator and its 434-case self-test pass on today's tree.
Checked by reading the definition and the validator in a checkout of main. The same rule in the bundled skill was verified separately in devantler-tech/agent-skills#122.
Activity
chore: agent-claim #214 nonce=93b6de76667a71161e5f86eaac13a442
fix(agentic-engineer): pin never-execute and Trust-gate wording in th…
devantler commentedon Oct 10, 2026
Verified after merge (2026-10-10)
Merged on 2026-09-15 and left in Verifying since. All three acceptance criteria hold on
maintoday, so this moves to Done.Checked by reading the definition and the validator in a checkout of
main. The same rule in the bundled skill was verified separately in devantler-tech/agent-skills#122.