Skip to content

fix(agentic-engineer): let the deployment decide whether external PRs may be merged #214

Closed

Description

@devantler

🤖 Generated by the Agentic Engineer

The generic Agentic Engineer role still forbids merging external-contributor pull requests, while the deployment that runs it has allowed that since 2026-08-08. The role and its consumer contract give opposite instructions for the same PR, and the role wins by default because it is the file the runtime loads.

Evidence

  • plugins/agentic-engineering/agents/agentic-engineer.agent.md (step 4, at main on 2026-09-15): External-contributor PRs are static-review-only: never merge them, never enable auto-merge on them, and never check out, build, or execute their branch code.
  • The consumer contract (devantler-tech/monorepo AGENTS.md, You own EVERY pull request in the portfolio) records a maintainer direction from 2026-08-08 that outside contributions are the engineer's to drive and merge. Their branches stay never-run-locally, and there are extra conditions before the merge: a current-head green review and a recorded CI-based evaluation.
  • The same contradiction exists in the bundled portfolio-maintenance skill, which devantler-tech/agent-skills authors (tracked separately there).

Who is affected

Every scheduled engineer run. An outside contribution that meets every gate is parked by the generic role, which is the passive self-blocking the consumer contract forbids.

Expected behaviour

The generic role keeps the execution guardrail unconditionally: never check out, build or run an external branch. Whether an external PR may be merged, and under what extra conditions, is resolved from the deployment's Trust gate and merge policy, not fixed in the generic text. A deployment that never allows it keeps today's behaviour.

Acceptance criteria

  • Step 4 separates "never execute an external branch" (unconditional) from "may merge" (deployment-resolved), and fails closed to no merge when the consumer contract does not grant it.
  • Auto-merge on an external PR stays forbidden (it merges a head nobody evaluated).
  • The plugin's manifest/contract validation pins the new wording so it cannot silently revert.

Rough size: small (one paragraph plus its validation).

Activity

  1. added theissue type on Sep 15, 2026
  2. moved this to 📥 Backlog in 🌊 Project Boardon Sep 15, 2026
  3. added a commit that references this issue on Sep 15, 2026
  4. moved this from 📥 Backlog to 👀 In Review in 🌊 Project Boardon Sep 15, 2026
  5. moved this from 👀 In Review to ✅ Done in 🌊 Project Boardon Sep 15, 2026
  6. moved this from ✅ Done to 📊 Verifying in 🌊 Project Boardon Sep 15, 2026
  7. devantler commented on Oct 10, 2026

    @devantler
    ContributorAuthor

    🤖 Generated by the Agentic Engineer

    Verified after merge (2026-10-10)

    Merged on 2026-09-15 and left in Verifying since. All three acceptance criteria hold on main today, so this moves to Done.

    • Never-run and may-merge are separate. The engineer definition says an external branch is never checked out, built or run, and that whether the PR may be merged comes from the consumer's Trust gate and merge policy; without that grant it is never merged.
    • Auto-merge on an external PR stays forbidden. Same paragraph: never enable auto-merge on them. The old sentence that forbade merging outright is gone.
    • The wording is pinned. The manifest validator asserts it, and that validator and its 434-case self-test pass on today's tree.

    Checked by reading the definition and the validator in a checkout of main. The same rule in the bundled skill was verified separately in devantler-tech/agent-skills#122.

  8. moved this from 📊 Verifying to ✅ Done in 🌊 Project Boardon Oct 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Fields

    Priority

    None yet

    Effort

    None yet

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions