[Taldres]

Lets the mobile app show who to follow as the web does. It follows #130 and is for the app's roadmap item, NativePHP/dev-null-app#72.

The web gets its suggestions as the suggestedUsers Inertia prop and dismisses them through POST /@{user}/dismiss, neither of which a signed request can reach. Both endpoints reuse what the web runs: SuggestedUsersQuery and CreateSuggestionDismissal.

Endpoints

GET /api/v1/me/suggested-users answers with the people the web would suggest, as UserResources: three to show and three spares to fill the place of one dismissed, as the web asks for them. Each one has followers_count, followed_by_following_count (new on UserResource, only set here) and follows_you for the reason line and the follow-back, and is_followed: false, as other lists of people say it. ?round=N is the next page of the day's picks, as the web's refresh button moves through them with its who_to_follow_round cookie. A missing or empty round is the first.

?username= or ?commit_id= asks for the suggestions as the web shows them beside that profile or commit since #1021: the people the profile follows, or the thread's other participants, come first, and the regular suggestions fill the rest. The commit has to be one the user can see, as its page requires, otherwise the answer is 422 with "That commit is no longer available." An unknown username is 422 too, and so is passing both. Across a block, a profile is ignored and the suggestions are the regular ones, as on the web. Without either, nothing changes.

{"data": [{"id": "…", "username": "octocat", "name": "The Octocat", "lane": 3, "followers_count": 12, "followed_by_following_count": 2, "follows_you": false, "is_followed": false, "…": "…"}]}

POST /api/v1/users/{username}/dismiss marks someone Not interested and answers 204. As on the web, they are never suggested again, nothing else changes, and dismissing yourself is 403.

Muted people, anyone across a block, and dismissed people are left out, as the query already does for the web.

Testing

Pint, Rector, PHPStan, type coverage at 100%, and all 4,149 tests pass locally (without the coverage driver, so line coverage is CI's to confirm). The new tests cover both halves of the mix, rounds, dismissals, mutes and blocks, the profile and commit context, commits the user can't see, validation, and unsigned requests, and that the endpoint answers what the web does for the same profile or commit page.

The app side is NativePHP/dev-null-app#74. It ran against this branch on an iOS simulator: following, dismissing with the spares moving up, and the next round. The app only shows who to follow in the Log, as the web does on smaller screens, so it doesn't pass a context.

[simonhamp]

@xHeaven @nunomaduro can we get this into the API so we can show "Who to follow?"

[xHeaven]

@xHeaven @nunomaduro can we get this into the API so we can show "Who to follow?"

The "Who to follow" algo changed a bit in #1021, can you guys check if this PR needs to be adjusted?

[Taldres]

Yep. I'll check it later

[Taldres]

@xHeaven @nunomaduro can we get this into the API so we can show "Who to follow?"

The "Who to follow" algo changed a bit in #1021, can you guys check if this PR needs to be adjusted?

@xHeaven Thanks for the hint! I updated the branch for #1021.

GET /api/v1/me/suggested-users now accepts the same context as the web:

• ?username= for a profile page
• ?commit_id= for a commit page (only commits the user is allowed to see)

Without these parameters, nothing changes. A test checks that the API returns the same suggestions as the web for the same page.