Repository navigation
fix: end the related commits' chain on a dot - #1257
Conversation
Related commits were listed below the thread's canvas, outside any, so each card drew its own rail, and the last one trailed a line to its card's edge with no dot to end it. They now chain one after the other in a canvas of their own and end on a dot below the last one, as search results and a feed do.
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Graph rendering and validation resources/js/components/related-commits.tsx, tests/Unit/StandaloneCommitGraphs.test.tsx |
RelatedCommits delegates rendering to RelatedCommitList, which wraps commits in GraphCanvas and marks the last commit with an end dot. The server-rendered test checks the canvas and rail output. |
Priority:
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Bug fix
Possibly related PRs
- dev-null-sh/dev-null.sh#1069: Adds the original related-commits component that this change updates.
- dev-null-sh/dev-null.sh#1135: Updates commit cards and graph rails to place end dots on commit rows.
- dev-null-sh/dev-null.sh#1150: Changes
GraphCanvasand its server-rendering handoff, which this change uses.
Suggested reviewers: younes-io
Merge Risk: 
Minimal · up to 0e84b
-
The related-commit chain and endpoint have no identified merge-blocking issues.
Pre-merge checks: 
4 · 
1
-
Failed checks: 1 warning Passed checks: 4 passedFull details: Docstring Coverage
-
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 2 files.
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
Summary
The last related commit under a thread trails its line down to the card's edge with no dot to end it. The list was rendered outside any graph canvas, so each card drew its own rail.
Changes
Validation
tsc, lint, format, node tests (206) and Vitest (723) pass locally. No PHP change.static,thread-open,chain): 78/78 in Chrome.Visual evidence
Chrome, desktop, same data. Before:
production. After: this branch.Device verification
macOS, Chrome through Playwright. No mobile interaction changes.
Independent review
Separate Claude agent, base
fa8d5407, head5b5ed3a7(since then only a comment added to the test and the commit footer removed, now0e84bcb4): CODE: PASS, VISUAL: PASS.Limitations
None.
Summary by CodeRabbit