Repository navigation
feat: offer /devup-retro at the end of the final completion report - #127
Merged
owjs3901 merged 1 commit intoNov 10, 2026
Merged
Conversation
When work that used devup-mcp is complete, the agent ends its final report with one question in the user's language offering the retrospective. - contract identifier offer-devup-retro-in-final-report (v5), stated in delivery-quality, devfive-frontend, devup, devup-implementation-plan, the OpenCode command and the usage guide - nextSuggestedAction on results that mark completion: runtime-audit completion reportAllowed, screen-plan status reportAllowed, stack-diff zero drift on every layer; never on exports, validation or failures - invocation is /devup-retro when the skill is installed, otherwise the MCP prompt form Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
owjs3901
marked this pull request as ready for review
November 10, 2026 12:39
owjs3901
deleted the
devfive/3099154426bffbeef8b62999b80bb038/devup-retro-offer
branch
November 10, 2026 12:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #126 (merged). User request: when work that used devup-mcp is finished, show a short message offering
/devup-retro, so there is always a path to keep improving.What the user sees
At the end of the agent's final completion report, once, in the user's language:
The invocation is the one that works in the workspace:
/devup-retrowhen the skill is installed, otherwise the MCP prompt form/mcp__<server>__devup-retro.Where the rule lives
offer-devup-retro-in-final-report(developmentContract v5, 21 requirements), explained in delivery-quality's identifier table and a new section "Final report: offer the retrospective"./devupcommand file.devup://guide/usage("After the work: /devup-retro") and the completion document.nextSuggestedAction:It is attached in exactly three places, decided by one function (
skills::marks_completion):devup_runtime_auditactioncompletionreportAllowed: true(stagedata-verified)devup_screen_planactionstatuscompletion.reportAllowed: true(already re-evaluates application completion)devup_stack_diffchecked: true, zero driftsDeliberately not attached
The brief listed
deliverable.isFinalanddevup_ui_validateas examples. I left both out, because they would break the "don't nag" requirement:deliverable.isFinalgrades generated source only; the completion document already says it never means the application is finished. An export is the first step of a task and happens once per frame.devup_ui_validateis run many times per URL during the work.Both are covered by a test that they never mark completion. If you want the hint there too, it is one match arm in
marks_completion.Don't-nag rules (in the text and in the hint)
Once per completed task; not after an intermediate call, a failure or an unresolved item; not again once asked; never run unasked.
Budgets
.rsfiles stay under 1000 lines.Tests
only_three_results_mark_completion: receipts, statuses and stack diffs with real shapes; non-final receipt, non-status action, drifted / skipped / partial stack, export withisFinal: trueand a clean validation all return falseonly_a_completion_result_carries_the_offer,an_installed_skill_is_offered_as_the_slash_command: hint present only when complete; MCP prompt form vs slash command; exact Korean messageevery_completion_text_states_the_offer_and_its_limits: delivery-quality, devfive-frontend, devup, devup-implementation-plan, guide and the OpenCode command contain the Korean and English sentence, the prompt form, "once" and "never run"completion_tests: the realdata-verifiedreceipt marks completionexport_project_theme: export reply has nonextSuggestedAction; 21 identifiers; headroomretro_command(stdio process): stack diff with nothing to compare, skills status and retro carry no hintLocal (Windows):
cargo insta test --workspace --all-features --check2325 passed, 0 failed, 2 ignored; clippy-D warningsand fmt clean; node tests 82 pass.Manifest bytes/sha256 updated for the four edited skill documents; changepack added (Minor).
🤖 Generated with Claude Code
Submitted via Devfive hub. Employee: ; device:
3099154426bffbeef8b62999b80bb038