Repository navigation
fix(windows): prevent console windows at every Core child-process boundary - #9
Open
ellmos-multi-bot wants to merge 1 commit into
Open
ellmos-multi-bot wants to merge 1 commit into
ellmos-multi-bot wants to merge 1 commit into
Conversation
Generated-with: Codex; session 01a164da-cc28-7140-b499-d40dae7c2e11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows background bot actions could open console windows because seven direct gh/git/ssh-keygen starts did not set CREATE_NO_WINDOW. A hidden Python parent does not automatically hide its console children.
This sets the Windows flag at all seven production boundaries, using zero on other platforms, and also protects the six direct subprocess starts in the existing tests. The standalone review-gate verifier remains standalone; credential, permission, preview/apply, signature and exact-head checks are unchanged. No version bump or installation is included.
Validation: two parametrized Windows/POSIX regression cases passed; they exercise all seven production adapters using fake runners and launch no real child processes. Ruff passed for the nine Python files, and git diff --check passed. An independent source review approved the exact ten-file content (SHA-256 acc3ab14bbef1a8209295740ac51b28e977079c41fa7b58ba6a590550957a60f) without open findings. Full hosted CI and independent merge review remain required.
Related operational scope: BACH #2071 and the explicit user request to prevent recurring console-window storms. The installed companion is not changed by this PR.
Generated-with: Codex; session 01a164da-cc28-7140-b499-d40dae7c2e11