Skip to content

fix: scaffold empty app lists and fill blank flag help - #273

Open
YoungDan wants to merge 2 commits into
mainfrom
cursor/fix-init-scaffold-and-help-f902
Open

YoungDan wants to merge 2 commits into
mainfrom
cursor/fix-init-scaffold-and-help-f902

Conversation

@YoungDan

@YoungDan YoungDan commented Nov 9, 2026

Copy link
Copy Markdown
Member

Summary

 destinations:
   - inventory_group: Workers
-    apps:
+    apps: []

init --provider github-token wrote a null apps: key. inventory validate requires a list, so an untouched scaffold failed with "apps must be a list". New groups and null blocks are now apps: []. Blocks that already list apps, or an inline value such as apps: [], stay as written.

Also adds one-line help for the 23 flags that rendered a blank description: --environment on the commands listed in #270, the enroll create limits, and the remediate analyse / draft filters.

Fixes #269
Fixes #270

Evidence

  • Before: generated YAML contained apps: with no value, and validate_environment_yaml reported apps must be a list. --help printed those flags with an empty description.
    After: generated_scaffold_passes_environment_validator passes for a Workers scaffold. previously_blank_flags_have_one_line_help checks all 23 flags, including the enrollment defaults (500 hosts, 30 days).

cargo fmt --check, cargo clippy --all-targets --all-features -- -D warnings, and cargo test --all-features passed locally.

Merge Danger

Door: two-way

The YAML change only rewrites null apps: keys to an empty list. Authored app entries are preserved. Help text does not change parsing.

Blast Radius: init and inventory sync output for empty destinations, plus --help text.

Review from Roger or Sai (RogerLindquist, SaikrishnaGundeti). Do not merge from this change.

Open in Web Open in Cursor 

cursoragent and others added 2 commits November 9, 2026 08:36
github-token init wrote a null apps key, which inventory validate
rejects as "apps must be a list". New groups and null blocks are now
an empty list; existing app entries stay intact.

Co-authored-by: Daniel Young <YoungDan@users.noreply.github.com>
Document the 23 options reported on groups, inventory, init, catalog,
license, remediate, upgrade, and enroll create, including units and
defaults for enrollment limits.

Co-authored-by: Daniel Young <YoungDan@users.noreply.github.com>
@YoungDan
YoungDan requested a review from a team as a code owner November 9, 2026 08:37

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants