Repository navigation
Conversation
github-token init wrote a null apps key, which inventory validate rejects as "apps must be a list". New groups and null blocks are now an empty list; existing app entries stay intact. Co-authored-by: Daniel Young <YoungDan@users.noreply.github.com>
Document the 23 options reported on groups, inventory, init, catalog, license, remediate, upgrade, and enroll create, including units and defaults for enrollment limits. Co-authored-by: Daniel Young <YoungDan@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
init --provider github-tokenwrote a nullapps:key.inventory validaterequires a list, so an untouched scaffold failed with "apps must be a list". New groups and null blocks are nowapps: []. Blocks that already list apps, or an inline value such asapps: [], stay as written.Also adds one-line help for the 23 flags that rendered a blank description:
--environmenton the commands listed in #270, theenroll createlimits, and theremediate analyse/draftfilters.Fixes #269
Fixes #270
Evidence
apps:with no value, andvalidate_environment_yamlreportedapps must be a list.--helpprinted those flags with an empty description.After:
generated_scaffold_passes_environment_validatorpasses for a Workers scaffold.previously_blank_flags_have_one_line_helpchecks all 23 flags, including the enrollment defaults (500 hosts, 30 days).cargo fmt --check,cargo clippy --all-targets --all-features -- -D warnings, andcargo test --all-featurespassed locally.Merge Danger
Door: two-way
The YAML change only rewrites null
apps:keys to an empty list. Authored app entries are preserved. Help text does not change parsing.Blast Radius: init and inventory sync output for empty destinations, plus
--helptext.Review from Roger or Sai (
RogerLindquist,SaikrishnaGundeti). Do not merge from this change.