Skip to content

feat: add family account management API - #793

Open
OfekAvergil wants to merge 2 commits into
mainfrom
feat/family-account-api
Open

feat: add family account management API#793
OfekAvergil wants to merge 2 commits into
mainfrom
feat/family-account-api

Conversation

@OfekAvergil

Copy link
Copy Markdown
Contributor

Related Issues

N/A

Description

Adds a new management.family module and family-related additions to management.user for the Descope family accounts feature:

  • New management.family module: create, update, delete, search, createDependent, deleteDependent, impersonateDependent, stopImpersonation
  • management.user.addFamilies / removeFamilies
  • familyAssociations option on user.create/update/invite/patch/createBatch/inviteBatch (via UserOptions/PatchUserOptions/User)
  • familyIds/dependent search filters on user.search
  • README docs for the new family module

Must

  • Tests
  • Documentation (if applicable)

Adds a new management.family module and family-related additions to
management.user for the Descope family accounts feature:

- New management.family module: create, update, delete, search,
  createDependent, deleteDependent, impersonateDependent,
  stopImpersonation
- management.user.addFamilies / removeFamilies
- familyAssociations option on user create/update/invite/patch/batch
  create (via UserOptions/PatchUserOptions/User)
- familyIds/dependent search filters on user.search
- README docs for the new family module

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@shuni-bot

shuni-bot Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

🐕 Review complete — View session on Shuni Portal 🐾

@shuni-bot

shuni-bot Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

🐕 Suggested Reviewers

This PR adds a new family account management module with comprehensive API coverage. The review assignment prioritizes: (1) deep architectural expertise with the most experienced contributors, (2) specific file domain knowledge for new family.ts and family.test.ts modules, (3) breadth across core infrastructure files (index.ts, paths.ts, types.ts), and (4) user management expertise since the PR integrates family features into existing user operations. Selected reviewers collectively cover all changed file areas with strong institutional knowledge of the management module structure.

Reviewer Reason
dorsha Most experienced contributor (34 commits) with broad coverage across README, index.ts, and paths.ts. Essential for validating architectural decisions and module structure integrity for the new family management feature.
aviadl Well-rounded contributor (6 commits across 6 files) who has touched all major file areas including index.ts, paths.ts, types.ts, and user management files. Ideal for cross-module consistency review.
asafshen User management specialist (4 commits in user.test.ts and user.ts). Critical for reviewing the user-family integration changes, especially the new familyAssociations options and related test coverage.
talaharoni Types and documentation expert (2 commits in README.md and types.ts). Important for reviewing the new type definitions introduced for the family feature and ensuring API documentation is clear.
orius123 Management module infrastructure specialist (4 commits in index.ts and paths.ts). Valuable for reviewing the new family module integration into the management module structure and API routing.

Suggested by Shuni based on git history and PR context. Names are not @-mentioned to avoid notifying anyone — request a review from whoever fits best.

@shuni-bot shuni-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐕 Shuni Review

Adds a new management.family module (create/update/delete/search, dependent management, impersonation) plus addFamilies/removeFamilies and familyAssociations/search filters on management.user.

Actionable comments posted: 0

Merge risk: 🟢 Low: new module follows existing SDK conventions (paths, transformResponse, spread-based body construction) exactly, the new familyAssociations/familyIds/dependent fields are correctly threaded through create/update/invite/patch/createBatch/inviteBatch/search via the existing generic spread/helper logic, and tests cover each new endpoint and field consistently with existing patterns.


Declared coverage: FULL — 8/8 changed files reviewed.

@shuni-bot

shuni-bot Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

🐕 Review complete — View session on Shuni Portal 🐾

@shuni-bot shuni-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐕 Shuni Review

No new issues found.


Declared coverage: PARTIAL — 3/8 changed files reviewed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant