Repository navigation
Open the 3.1 cycle after 3.0.0 - #1175
Merged
Merged
Conversation
VERSION (3, 1, 0) and PRE_RELEASE "dev", so the tree reports 3.1.0dev, above 3.0.0 and below 3.1.0, with the version comments naming the new versions; and a 3.1.0 Unreleased entry in the release log. CITATION.cff stays at 3.0.0, the last released version. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
compare.py's baseline worker recorded the seven fields, the reports, initials() and the case views, but not the generation, credentials, honorifics, patronymic and surname2 views snapshot.read() records since 3.0, so against 3.0.0 every name filling one read as moved: a bare run reported 669 of 7,107 entries in a tree that moved none. The worker now reads each view as the tree side does, says which views the wheel's ParsedName has, and unrecorded() leaves out the ones a 2.x baseline lacks, as it does the alternatives before 2.7 (--baseline 2.8.0: 1,669 entries with the views compared, 1,155 without). DEFAULT_BASELINE is 3.0.0, against which the tree now reads 0 moved. A test ties the worker's views to snapshot.RECORDED_LATER, so a view added to the snapshot and not the worker fails there. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The case-view rows assert they still reach their arm; the three 3.0 view rows passed an empty set and checked nothing of the kind, so a vocabulary change that stopped 田中さん filling honorifics would leave the row passing while testing nothing. Each now names its views. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opens the 3.1 cycle after 3.0.0 (release checklist steps 8–9), in the same shape as #936, and fixes the comparison harness defect that step 8's check turned up.
VERSION = (3, 1, 0)andPRE_RELEASE = "dev", so the tree reports3.1.0dev, which normalizes to 3.1.0.dev0: above 3.0.0 and below 3.1.0. The_version.pycomments name the new versions.* 3.1.0 - Unreleasedentry says 3.1 refuses aLexicon,Parseror locale pack pickled by 2.x, which 3.0 loads with aDeprecationWarning(the 3.0 deprecation bullet).compare.py'sDEFAULT_BASELINEis now"3.0.0".The harness fix. The first bare
compare.pyagainst the 3.0.0 wheel reported 669 of 7,107 entries moved, in a tree whosenameparser/is the release's plus the version bump. The baseline worker recorded the seven fields, the reports,initials()and the case views, but not thegeneration,credentials,honorifics,patronymicandsurname2viewssnapshot.read()records since 3.0, so every name filling one read as moved. Against 2.8.0, the baseline of the whole 3.0 cycle, that was invisible: no 2.x wheel has those views, so each move was a real new key.getattr(p, key, "")) and its version tell names the views the wheel'sParsedNamehas.unrecorded()leaves out the views a baseline lacks, as it already did the alternatives before 2.7: a name the tree fills a new view for is not a name that moved.--baseline 2.8.0now reports 1,155 entries where the old harness reported 1,669 (2026-11-08); no committed figure was taken from a bare 2.8.0 run.test_the_worker_views_are_every_view_a_snapshot_recordsties the worker's views tosnapshot.RECORDED_LATER, so a view added to the snapshot and not the worker fails there. With the pre-fixcompare.py, six of the new and changed tests fail; with the fix all pass.Checks. Bare
compare.py: 0 of 7,107 entries read differently from 3.0.0. The full suite (40,191 passed), the serial benchmark tests (60), the HTML docs build, mypy and ruff pass.Reviews.
snapshot.read(), checkedunrecorded()for each kind of tell, ran the new tests against the pre-fixcompare.py, and reproduced every figure above (0, 1,155, 1,669, 669). One point taken: the three view rows now assert they still reach their view, as the case-view rows do (fix commit, checked by listing each row's views and a name without one). Two left as they are: the 3.1 release-log line states the cycle's plan, as Open the 3.0 cycle after 2.8.0 #936's did for 3.0, and theassertinunrecorded()reads a tell our own worker writes.🤖 Generated with Claude Code