Repository navigation
Release sweep for 3.0: stale prose since the first sweep - #1173
Merged
Merged
Conversation
The release checklist's stale-prose sweep, over the commits since 2d91f6b (#1079): migrate.rst's "Changed in 3.0" list gains the ten late shapes 1.4.0 read differently, each with a doctest; the CLI section documents --lone-name-word; the lone-word, VI CHI, PT piedade, two_family_names help and classify tag-list prose is brought in line with the tree; rules/O4 and S3, one decisions entry, and four AGENTS.md files are corrected. Adds the MD.Filho row to period_joined_credential's table and fixes vi.py's DEVIATES wording. O4's budget is re-recorded for one clause pointing at O5. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Dates the vocabulary-model correction and states C6's condition; gives O4's one-word pointer its own bullet; scopes concepts.rst's lone-word sentence to name_order; adds a family comma to the lists of what decides a lone word first; dates pt.py's count of default-off readings; aligns customize.rst's two_family_names row with the CLI help; says the MD.Filho row shares Msc.Filho's path. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Restores the three-letter and C4 limits the first fix dropped from the vocabulary-model correction, with the one-name-word contrast; names the script exception in concepts.rst's lone-word sentence; gives customize.rst's family comma its two directions; untangles pt.py's opening sentence; names the code comment the MD.Filho row copies. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Scopes the vocabulary-model CHI clause to the part right after the first comma, adding that past a second comma CHI stays a suffix in any case (rules/C2); concepts.rst's lone-word sentence names a title. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release checklist's stale-prose sweep (root AGENTS.md, Release checklist, step 0) over the 46 commits since the first sweep (#1079, 2d91f6b), run after the simplify passes (#1153, #1154, #1157, #1158). Docs and comments only:
tools/differential/snapshot.jsonlis byte-identical to master.Sites walked
--lone-name-word(#1114 listed it in--helponly). customize.rst'stwo_family_namesrow says the first two under a family-first order, and its lone-word section names a family comma (both directions) and the kana that settle order. concepts.rst says how a one-word name is placed (a title or a script that settles order deciding first). locales.rst: undervi,CHIafter a comma stays a suffix only in a mixed-case name (NGUYEN VAN ANH, CHIreads givenCHI).PYTHONSAFEPATH=1, outside the worktree)John Smith y V, NFD이서연·김민준,Priv.-Doz.,PhD/NP-CandMA/PhD,(Ma, PhD)and(Msc.Ed),'Smitty' Jones Jr.,Mohd., the five titles no name bears,Mary Smith, Mst. The pickle paragraph's "23 credentials and 13 case masks" was a standing count, now stale (a 2.8.0Lexicon.default()pickle lacks 108 credentials and 72 masks, measured 2026-11-07), so the number is dropped; no test held it.python -m doctest README.rst;readme_renderer; announcement read_policy.py,_types.py,_parser.py,_lexicon.py,_locale.py,locales/*.py,__main__.pylocales/pt.pynames the default-off reading it turns on (piedade, #1118/#1122).locales/vi.py:DEVIATESdeclares a name holding a letter or a digit; theCHIclause as above.Policy.name_orderpoints atlone_name_word.--two-family-nameshelp said "the last two"; the first two under a family-first--order. Nothing pins the help text._pipeline/*.pyReads: linesvocab:joined-title(#1104) andvocab:title-case-name(#1039); added.a_suffixed_family_before_a_comma_suffix_reads_positionallysaidSmith Jr.alone reads as it does before the comma; alone it reads given and reportsgiven-or-family(O5).John Smith MAno longer keeps the family (S6 reads it); nowJohn Smith Ma. decisions/vocabulary-model's 2026-11-05 #1108 entry corrected in place, with a dated note: the capitals shape takesCHIafter a comma in the part right after the comma only where the name's case contrasts and two name words stand before it (past a second comma it is a suffix in any case), and only because the pack removes its credential reading._assemble's Reads: reason;--locale vinow thatlocales.VIexists; the snapshot records each report's alternative; the command block mentions the CLI flags._pipeline/AGENTS.md: the two-way-fork example (John Smith MA/Jack MAno longer report it) is nowJohn Smith V/John V.vocab/AGENTS.md: PARTICLES ∩ TITLES includes the ranks (#709). docs/, docs/design/ and nameparser/AGENTS.md: checked, nothing stale.Also folded in from the simplify passes: a
("MD.Filho", False)row inperiod_joined_credential's table. It fails with S11's clause removed, but so does the existingMsc.Filhorow by the same path, so the clause was already guarded; the row stays as the example the code comment names.M.Filho, the row with no settling chunk, passes with the clause removed, and is the one S11 row that is no control.Follow-up, not done here
rules/O5 glosses a family comma as "a comma with a name segment after it", but
Anh, Jr.andAnh, PhD, which have none, are decided (familyAnh) and silent too. The gloss or an Except bullet citing C8 would make O5 say what the parser does. A rule change, so not part of a prose sweep.Reviews
MD.FilhoduplicatesMsc.Filho; customize.rst'stwo_family_namesrow). All fixed in d37e7bd.Nguyen Van Anh, DO,Anh, CHIcontradicted it). Restored, with clarity fixes, in the third commit.CHIa suffix in any case (NGUYEN, VAN ANH, CHI). concepts.rst's lone-word sentence also omitted a title (Mr. Johnson). Both fixed in the fourth commit, whose examples were verified by running them, with no fourth review round.Checks
uv run pytest(40,186 passed, 6 skipped, 5 xfailed),uv run pytest -n0 -m serial(60 passed),sphinx-build -b doctest(0 failures),-b html,uv run mypy,uv run ruff check,python -m doctest README.rst, readme_renderer.🤖 Generated with Claude Code