Repository navigation
Count a family part's particles out of its numeral count (#1080) - #1091
Merged
Merged
Conversation
rules/C1's numeral site in the family part counted the pieces in front of a one-letter numeral, and an unjoined particle is a piece of its own there, so `SMITH VD V, JOHN` read family 'SMITH VD', suffix 'V', and `van der V, John` family 'van der', suffix 'V'. A run of pieces made wholly of particles right in front of the numeral is now left out of the count, as P9 (a particle that is also a suffix word, beside a family comma) already said: the letter reads as the part without the particle reads it. 1.4.0 through 2.6.0 read these as family; 2.7.0 through 2.8.2 read the suffix (#886). - P9's two deviates: #1080 markers removed - decisions/P9 entry with the grid measurement and local corpora - case rows for the fix and two boundaries (a joined particle surname, a particle behind two name words) - nameparser/AGENTS.md: a count inside a part follows C3 too Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Address the review of the first fix:
- _names_before counts the pieces in front of the numeral that are not
wholly particles, wherever they stand, so a particle opening the part
is no word to spare either ('de Mesnil V, Jean', 'van Smith van V,
John' keep the V in the family, as 1.4.0 through 2.6.0 read them)
- S10 states the count in its family-comma bullet, with examples, and
C1's sentence that the family part reads its numeral as the
comma-less name does gains its exception ('John van der V, M.J.')
- P9's clause is scoped to a letter ending the part, and its mixed-case
example is fenced; the 'vd V Jr.' shape is recorded as not decided
- decisions/P9: corrected release history (2.2.0 and 2.3.0 read
'SMITH VD V' otherwise), the grid re-measured (4,398 of 34,992 move,
1,466 per order), and two FEC names that now move recorded
- case rows for a title head, a third comma part, the I spelling, a
leading particle and paired initials; release-log lead says "family
comma"; rule sizes, rules corpus and snapshot re-recorded
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Address the second review of the fix commits: - decisions/S10 gains the Standing line and a Log entry for the count, which is S10's; the full record stays in decisions/P9 - head notes on decisions/C1's #774 entry and vocabulary-model's 2f sites bullet, which restate the count over every piece - release ranges: 'smith vd v, john' ('vd, v' through 2.2.0, 'vd v' in 2.3.0 and 2.4.0), 'Smith van der V, Jr.' (2.2.0 on), and the title row's note (2.5.0 and 2.6.0 read as here) - the release-log bullet says the de Mesnil reading moved, and names the generation it reads as part of a particle surname Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1080
What moved
Before a family comma, a one-letter roman numeral read as the generation from 2.7.0 on wherever a particle stood in the part, the particle counted as a name word to spare:
SMITH VD V, JOHNSMITH VD V¹SMITH VD, suffixVSMITH VD VSmith van der V, JohnSmith van der VSmith van der, suffixVSmith van der Vvan der V, Johnvan der Vvan der, suffixVvan der Vde Mesnil V, Jeande Mesnil Vde Mesnil, suffixVde Mesnil VJohn van der V, M.J.John van der VJohn van der, suffixVJohn van der V¹ 2.2.0 and 2.3.0 read family
SMITH V, suffixVD(#573).Why
rules/C1's numeral site in the family part (
_assign._family_part_numeral, added by #886) asks rules/S10's (the trailing roman numeral) words-to-spare count: a one-letter numeral needs two name words in front of it. It counted pieces, and a particle no chain has joined to a name word is a piece of its own there._names_beforenow counts only the pieces that are not wholly particles: the comma has named the part a surname, where a particle heads the name word behind it, so it reads as part of that word, as rules/C3 (counting the words before the comma) counts a particle run.Rules amended
Smith van der V,de Mesnil Vand theSmith van der Berg Vboundary as examples. The clause reads the signal S10 already reads there (its words-to-spare count), so it is not a new rule.John van der V, M.J.. The comma-less name has a given name a particle may follow; a family part has none.deviates: #1080markers are gone, the clause is scoped to a letter ending the part, and its mixed-case example (Smith vd v, John) is now fenced.rules_budget.json): C1 454 → 476 words, P9 405 → 420, S10 665 → 721, each for the clause above.Boundaries (case rows)
Smith van der Berg V, Johnkeeps suffixV: a joined chain is one name word, so two stand in front, as inSmith Jones V, John.Smith Jones van V, Johnandde Mesnil Jones V, Jeankeep suffixV.John van V, and the part before a suffix comma (Smith van der V, Jr.) do not move.Mary Smith vd V Jr., Johngives familyMary Smith vd V), where the part without the particle reads it as the numeral. It reads the same on master and is recorded in decisions/P9.Measured
suffix-or-name.SMITH VD V, JOHNandsmith vd v, johnmove, plus five rule examples new to the rules corpus.ctgov-officialsandtse-donorsdo not move.fec-individualsmoves two:DU HART V, JOHN(suffixV→ familyDU HART V) andVAN METER V, ISAAC C IV(generationV, IV→ familyVAN METER V, generationIV). In FEC'sFAMILY SUFFIX, GIVENwriting bothVs are most likely generations. It is the cost S10's count already takes for a one-word surname (SMITH V, JOHNreads familySMITH Von master), and it is 1.4.0's through 2.6.0's reading. Decided: accepted (decisions/P9's Why does "SMITH VD V, JOHN" lose the V from the family name when "SMITH V, JOHN" keeps it? #1080 entry). The first draft, which left out only particles right in front of the numeral, moved neither.Checks
uv run pytest,uv run pytest -n0 -m serial,uv run mypyanduv run ruff checkpass. Reviewed by the design-docs, code, test and comment reviewers; the second commit addresses their findings. A second round (code and design docs) reviewed the fix commits: it found no code defect, and the last commit files the count under decisions/S10, adds head notes to the two entries that restated the old count (decisions/C1 #774, vocabulary-model 2f), and corrects three release ranges.Not done here: the connective twin
Smith y V, John(suffixV, familySmith y Vin 1.4.0 and 2.6.0), which the test review found and which is a separate rule, now #1093.🤖 Generated with Claude Code