Skip to content

docs: fix dead Haystack docs links and nightly badge - #494

Merged
bilgeyucel merged 1 commit into
deepset-ai:mainfrom
sarankumar1325:docs/fix-dead-doc-links
Nov 3, 2026
Merged

bilgeyucel merged 1 commit into
deepset-ai:mainfrom
sarankumar1325:docs/fix-dead-doc-links

Conversation

@sarankumar1325

Copy link
Copy Markdown
Contributor

This PR fixes dead links in the README and four tutorials. Each old link returns 404:

  • README: the "Run Tutorials Nightly" badge pointed at .github/workflows/nightly.yml, which no longer exists. The nightly run is now run_tutorials.yml (cron 0 0 * * *), so the badge and link point there.
  • Tutorial 33: docs/drawing-pipeline-graphs is now docs/visualizing-pipelines.
  • Tutorials 36 and 39: docs/setting-the-log-level is now docs/logging#changing-the-log-level.
  • Tutorial 47: docs/confirmationhook and docs/blockingconfirmationstrategy don't exist. Both classes are documented on docs/human-in-the-loop, so the links point there.

I checked each new URL with curl (all return 200) and made sure the notebooks still parse as JSON. Only markdown link targets change; no code cells are touched.

AI assistance: I used an AI coding assistant to find and check the dead links, and I reviewed the change myself.

@sarankumar1325
sarankumar1325 requested a review from a team as a code owner October 30, 2026 23:27
@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@bilgeyucel

Copy link
Copy Markdown
Contributor

Thank you for the contribution @sarankumar1325 !

@bilgeyucel
bilgeyucel merged commit 21a2631 into deepset-ai:main Nov 3, 2026
3 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants