Repository navigation
suunto_nautic: cancel during a /Data stream, page cap, temperature order - #11
Merged
Merged
Conversation
…cap, order the temperature pair A long dive streams for minutes and the cancel callback was only checked before each request, so a stopped sync kept downloading. Check it between stream frames, and still stop the stream so the watch doesn't keep sending. MAX_PAGES 64 truncated a dive's Descriptors schema (about 97 pages); raise it to 512. The Ocean can store the /Summary temperature pair reversed (the app then shows Min 29.35, Max 18.85 C); order it instead of falling back to the sampled range.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From trustthegoose's DC Tester 17 results on libdc-swift#29.
DC_STATUS_CANCELLED.MAX_PAGES64 → 512: a dive's Descriptors schema is about 97 pages and was truncated.Tests live in libdc-swift, in the PR that bumps this submodule.
🤖 Generated with Claude Code