Skip to content

chore(deps): convert package-lock.json to lockfileVersion 3 #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tkislan wants to merge 2 commits into
base: main
Choose a base branch
from
+23 −25,372
Open

chore(deps): convert package-lock.json to lockfileVersion 3 #557

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2706808
chore(deps): convert package-lock.json to lockfileVersion 3
tkislan Oct 7, 2026
57f5e72
ci(qlty): add osv-scanner exceptions for the root lockfile
tkislan Oct 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,9 +96,9 @@ jobs:
if: "!cancelled() && github.event_name != 'pull_request'"
run: qlty smells --all

# osv-scanner declares skip_upstream, so only --all ever sees a lockfile. The root
# package-lock.json is too large for qlty to analyze (better-npm-audit gates it in the
# audit-* jobs), so in practice this gates src/test/vscode-notebook-perf/package-lock.json.
# osv-scanner declares skip_upstream, so only --all ever sees a lockfile. Accepted risks for
# the root package-lock.json live in osv-scanner.toml, mirroring .nsprc. qlty silently skips
# files over 2,098,000 bytes, so the root lockfile drops out of this scan if it grows past that.
Comment on lines +100 to +101

@m1so m1so Oct 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

slight scope creep, but can't this be a (deterministic) pre-check before running the qlty check itself? e.g. fail CI when the file is not scannable?

- name: Run qlty dependency scan
if: '!cancelled()'
run: qlty check --all --filter=osv-scanner
Expand Down
4 changes: 2 additions & 2 deletions build/ci/postInstall.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ function verifyMomentIsOnlyUsedByJupyterLabCoreUtils() {
const packageLock = JSON.parse(fs.readFileSync(packageLockPath, 'utf8'));
const packagesAllowedToUseMoment = ['node_modules/@jupyterlab/coreutils', '@jupyterlab/coreutils'];
const otherPackagesUsingMoment = [];
['packages', 'dependencies'].forEach((key) => {
['packages'].forEach((key) => {
if (!(key in packageLock)) {
throw new Error(`Invalid package-lock.json, as it does not contain the key '${key}'`);
}
Expand All @@ -152,7 +152,7 @@ function verifyMomentIsOnlyUsedByJupyterLabCoreUtils() {
) {
return;
}
['dependencies', 'requires'].forEach((dependencyKey) => {
['dependencies', 'optionalDependencies'].forEach((dependencyKey) => {
if (dependencyKey in packages[packageName]) {
const dependenciesOfPackage = packages[packageName][dependencyKey];
if ('moment' in dependenciesOfPackage) {
Expand Down
17 changes: 17 additions & 0 deletions osv-scanner.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
# Accepted risks for the root package-lock.json, scanned by qlty's osv-scanner plugin.
# Mirrors .nsprc (better-npm-audit), which holds the full assessment: keep both in sync.

[[IgnoredVulns]]
id = "GHSA-848j-6mx2-7j84"
ignoreUntil = 2026-10-17
reason = "CVE-2025-14505 (elliptic): dev-only, via node-stdlib-browser; no patched release. See .nsprc."

[[IgnoredVulns]]
id = "GHSA-vfj7-8cjw-p6xm"
ignoreUntil = 2026-11-06
reason = "CVE-2026-93687 (braces): not shipped, not reachable with untrusted input; no patched release. See .nsprc."

[[IgnoredVulns]]
id = "GHSA-hp3w-g68c-fv3c"
ignoreUntil = 2026-11-06
reason = "CVE-2026-97058 (sprintf-js): not shipped, not reachable; no patched release. See .nsprc."
Loading
Loading