Repository navigation
chore(server): remove jest from runtime dependencies - #32
Merged
Merged
Conversation
jest ^26.0.1 has been listed under both `dependencies` and `devDependencies` of packages/server since f5b085b ("migrate testing tool to jest", 2020-05-16). Nothing under src/, bin/ or npm_bin/ loads it at runtime. It is only the test runner, and the devDependencies entry stays. Because it was a runtime dependency, every consumer of @deepnote/sql-language-server installed the whole jest 26 tree in production. In vscode-deepnote that put jest, @jest/*, micromatch, braces and sprintf-js into `npm audit --omit=dev`, so their advisories failed the production audit gate. yarn.lock is unchanged: `yarn install --frozen-lockfile` accepts it, since the devDependencies entry keeps the same `jest@^26.0.1` resolution. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01USEnGCRP32gQH4AZHbRVqQ
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01USEnGCRP32gQH4AZHbRVqQ
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. 3 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour. 📝 WalkthroughWalkthroughThe server package version changes from 3.0.0 to 3.0.1. The production Jest dependency is removed. The development Jest dependency remains. Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other Merge Risk: ⚪ Minimal · up to The package's published runtime does not depend on Jest, while its test workflow still has Jest available. No merge-blocking risk is identified. 🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
Comment |
tkislan
marked this pull request as ready for review
October 7, 2026 08:09
mfranczel
approved these changes
Oct 7, 2026
m1so
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
jestfrom the runtimedependenciesof@deepnote/sql-language-server(packages/server) and bumps the package to3.0.1.jeststays indevDependencies, where it already was.Why
jesthas been listed in both sections since upstream commit f5b085b ("migrate testing tool to jest", 2020-05-16).src/,bin/ornpm_bin/loads it. It is only the test runner ("test": "jest").bracesandsprintf-js.Effect on a production install
Measured with
npm install --omit=devof the packed tarball vs the published3.0.0, each in a clean directory:node_modulessizeVerification
yarn install --frozen-lockfilepasses andyarn.lockis unchanged. The devDependencies entry keeps the samejest@^26.0.1resolution.yarn npm:prepublishyarn lintyarn vsc-compile:clientyarn vsc-compile:serveryarn test:server: 8 suites, 135 passed, 3 skippedtest:parserandtest:sqlint, since those packages are untouched.dist/src/index.jsloads.dist/bin/vscodeExtensionServer.jsanswers an LSPinitializerequest with the same capabilities as 3.0.0:textDocumentSync,completionProvider,renameProvider,codeActionProviderandexecuteCommandProvider.Release
packages/serveris bumped.sql-parserandsqlintare unchanged and stay at3.0.0.publish.yamlsets the version from thev*tag, so the release tag should bev3.0.1.🤖 Generated with Claude Code
https://claude.ai/code/session_01USEnGCRP32gQH4AZHbRVqQ