fix: preserve root $ref base directory in check_value - #167
Merged
njzjz merged 1 commit intoAug 31, 2026
Conversation
Pass the directory returned while resolving a root $ref into the subsequent traversal so nested relative references resolve beside their declaring file. Add a regression test that distinguishes the source directory from the process working directory. Coding-Agent: Codex Codex-Version: codex-cli 0.151.0 Model: gpt-5.6-sol Reasoning-Effort: xhigh
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #167 +/- ##
==========================================
+ Coverage 78.89% 78.91% +0.02%
==========================================
Files 9 9
Lines 886 887 +1
==========================================
+ Hits 699 700 +1
Misses 187 187 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
njzjz
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$refinArgument.check_value().Validation
python -m unittest discover -v— 64 passed, 4 skipped (IPython not installed)ruff check dargs testsruff format --check dargs teststy check dargs/dargs.py— no errors; existing deprecatedsrc.rootwarning onlyCoding agent: Codex
Codex version: codex-cli 0.151.0
Model: gpt-5.6-sol
Reasoning effort: xhigh