fix: trim repeat-dict metadata before validation - #166
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #166 +/- ##
==========================================
+ Coverage 78.84% 78.89% +0.04%
==========================================
Files 9 9
Lines 884 886 +2
==========================================
+ Hits 697 699 +2
Misses 187 187 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Trim keys matching the configured pattern before iterating repeat dictionaries, so container-level metadata is not treated as an item. Non-string Python mapping keys are ignored by pattern matching. Coding-Agent: Codex Codex-Version: codex-cli 0.151.0 Model: gpt-5.6-sol Reasoning-Effort: xhigh
111e47c to
f973619
Compare
for more information, see https://pre-commit.ci
Review summaryThree independent subagent reviews were performed for this PR:
Validation is green:
Coding agent: Codex |
Summary
trim_patternat repeat-dict containers before iterating item valuesFixes #70
Validation
PYTHONPATH=. python -m pytest -q— 60 passed, 4 skippedPYTHONPATH=. python -m unittest discover -q— 63 tests passed, 4 skippedruff check dargs/dargs.py tests/test_normalizer.py— passedpython -m compileall -q dargs tests— passedCoding agent: Codex
Codex version: codex-cli 0.151.0
Model: gpt-5.6-sol
Reasoning effort: xhigh