Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ESolver_KS::iter_init()for both PW and LCAO.iter_init_dftu_pw()andfinish_dftu_lcao().Verification
OMP_NUM_THREADS=1 ctest --test-dir /home/lanshuyue/abacus/ABACUS/abacus-develop/build --output-on-failure -R '^(MODULE_PW_dftu_base_test|MODULE_DFTU_base_io)$': 2/2 passed outside the restricted process environment. These are existing binaries from the neighboring checkout, so they validate the existing DFT+U I/O behavior but do not exercise the newly built solver.python3 tools/03_code_analysis/agent_governance_check.py --staged: no errors; warnings addressed below.git diff --check: passed.Review notes
PARAM.globalv.global_out_dirreference moved from the PW solver call site to the shared KS solver; the PR-wide global dependency count is unchanged. The shared output entry point still needs this directory until it is passed through a broader solver configuration change.ESolver_KSfixture would expand this small orchestration change substantially. Full PW/LCAO runtime validation remains for CI/review.