Repository navigation
Governance: enforce approved exceptions and align default-arg severity - #8225
Merged
mohanchen merged 1 commit intoOct 29, 2026
Conversation
- Checker: parse the `### Governance Exception` PR section and the `governance-exception-approved` label from the event payload. A complete, approved exception downgrades blocking findings whose rule is named in `Rule` to warnings; findings with allow_exception=False are never downgraded. Incomplete or unapproved exceptions emit a warning and keep the blocker. - Workflow: re-run on labeled/unlabeled so applying the label takes effect. - Docs: the rule matrix listed "New default parameter" as block while the checker (and its test) warn; align the doc to warn. Document the exception approval flow in agent_governance.md and AGENTS.md. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ABACUS-PR-BOT
left a comment
ABACUS-PR-BOT
left a comment
Collaborator
There was a problem hiding this comment.
Static review of 3dc028a1abec5930f476b149aa5f07d2d44cd939. The candidate checker/tests and workflows were not executed; CI diagnostics were unavailable.
Non-blocking: Please add the actual checker-regression command and observed result to the PR verification notes, or state which checks were not run and why. The checked reminder currently has no accompanying evidence; a follow-up documentation update is fine.
mohanchen
approved these changes
Oct 29, 2026
mohanchen
pushed a commit
to mohanchen/abacus-mc
that referenced
this pull request
Oct 29, 2026
Resolve conflicts with upstream/develop (PR deepmodeling#8225, deepmodeling#8214, deepmodeling#8230, deepmodeling#8223): - write_dipole.cpp grid validation: take upstream version, which rejects only the inconsistent state (nplane == 0 && nrxx != 0) while allowing legitimate empty partitions; a superset of our nplane fix (13b21fb). - write_dipole.cpp file write: keep our MY_RANK == 0 guard (fixes UB of writing to an unopened stream on non-root ranks) wrapping upstream's new setw/scientific output format. - source_io/unittests/CMakeLists.txt: adopt upstream's test/ -> unittests/ rename and test_<module>.cpp file naming (rule 11), while keeping our stru_frame_io.cpp link additions; read_set_globalv.cpp still calls stru_frame_io::extract_last_frame, so the dependency remains. Verification: conflict markers cleared, no stale references to old test file names, all SOURCES entries point to existing files; build not rerun locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reminder
AGENTS.mdanddocs/developers_guide/agent_governance.md.source/changes.When I'm trying to update the goverance check, I found some problems with it so I made this PR to fix them first.
This change does two things: