Repository navigation
Feature: Enable noncollinear magnetism and SOC in PW RT-TDDFT with the ETRS propagator and adaptive time stepping - #8223
Open
AsTonyshment wants to merge 28 commits into
Open
AsTonyshment wants to merge 28 commits into
AsTonyshment wants to merge 28 commits into
Conversation
ABACUS-PR-BOT
left a comment
Collaborator
There was a problem hiding this comment.
Static review at 8c0bcc47c819b80a7cadcd7cedd1a0c7b76ca04e. git diff --check 00d74be8e24cd9e7ab3537c8088f8bada783ab4c 8c0bcc47c819b80a7cadcd7cedd1a0c7b76ca04e passed; the trusted governance check on the identical parent tree returned warnings only (21 global references added/21 removed).
No builds or product/numerical/GPU/MPI tests were run; CI diagnostics were unavailable. These are bounded static findings, not runtime or CI validation.
Please provide reference-generation commands and measured platform/compiler/MPI deviations supporting the widened tolerances, including case 31's 1e-10 to 5e-10 change.
…rrent, and torque outputs
…ngs from ETRS tests
…ary global dependencies
…DFT workflow readability
…, and output control with consistent naming
…s with explicit dependencies and clarify naming
… and empty plane-wave partitions
… timings, and replace CUDA triangular inversion with cuBLAS TRSM
AsTonyshment
force-pushed
the
feat/rt_nspin4
branch
from
October 28, 2026 03:51
b4a6d3c to
a9318a9
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
nspin=4), including spin-orbit coupling, on CPU and GPU.scf_nmax) and real-time propagation (td_scf_nmax).01_PW/087_PW_get_pchg_kpar_bndpar,01_PW/089_PW_get_wf_kpar_bndpar, and01_PW/scf_uspp_bpcgthrough tighter convergence, refreshed references, and case-specific tolerances. (Useful information for testing on 北极星 and 天津超算)11_PW_GPU/scf_bpcgby using cuBLAS TRSM. (Also an already known defect)Tests
As a physical demonstration, we simulated a fixed-ion Fe dimer (Fe₂) with a 1.99 Å bond along the z axis, using PBE and the ETRS propagator. Gaussian-envelope electric pulses polarized along the bond were applied. The figure below shows the applied fields and the total magnetic moment$M_z(t)$ for three pulse amplitudes with SOC, together with a calculation without SOC at the highest amplitude.