Skip to content

Precommit: Format source_hsolver (Part I) - #8199

Open
Growl1234 wants to merge 3 commits into
deepmodeling:developfrom
Growl1234:precommit-3
Open

Precommit: Format source_hsolver (Part I)#8199
Growl1234 wants to merge 3 commits into
deepmodeling:developfrom
Growl1234:precommit-3

Conversation

@Growl1234

@Growl1234 Growl1234 commented Oct 22, 2026

Copy link
Copy Markdown
Collaborator

Reminder

  • I have read AGENTS.md and docs/developers_guide/agent_governance.md.
  • I have linked an issue or explained why this PR does not need one.
  • I have added adequate unit tests and/or case tests, or explained why not.
  • I have listed the exact verification commands run and their results.
  • I have described user-visible behavior changes, including INPUT parameter changes.
  • I have explained core-module impact for ESolver, HSolver, ElecState, Hamilt, Operator, Psi, or other source/ changes.
  • I have requested any needed governance exception below.

Linked Issue

Fix #

Unit Tests and/or Case Tests for my changes

  • Commands run:
  • Result summary:
  • Checks not run, with reason:

What's changed?

  • Example: brief summary of the user-visible or developer-facing change.

Governance Notes

  • INPUT/docs changes:
  • Core module impact:
  • Exceptions requested:

@Growl1234 Growl1234 added Refactor Refactor ABACUS codes The Absolute Zero Reduce the "entropy" of the code to 0 labels Oct 22, 2026
@Growl1234 Growl1234 changed the title Precommit: Prettify source_hsolver (Part I) Precommit: Format source_hsolver (Part I) Oct 22, 2026
ZhouXY-PKU
ZhouXY-PKU reviewed Oct 22, 2026
View reviewed changes
Comment thread source/source_hsolver/kernels/cuda/hegvd_op.cu Outdated
// calculate the sizes needed for pre-allocated buffer.
CHECK_CUSOLVER(cusolverDnDsygvd_bufferSize(cusolver_H, CUSOLVER_EIG_TYPE_1, CUSOLVER_EIG_MODE_VECTOR, uplo, n,
A, lda, B, ldb, W, &lwork));
CHECK_CUSOLVER(cusolverDnDsygvd_bufferSize(cusolver_H,

@ZhouXY-PKU ZhouXY-PKU Oct 22, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too many lines?

Comment thread source/source_hsolver/kernels/linear_op.cpp Outdated
const int j = band * ld + i;
out[j] = direction ? x[j] + a[band] * (out[j] - b[band] * y[j]) : (out[j] + a[band] * x[j]) + b[band] * y[j];
out[j]
= direction ? x[j] + a[band] * (out[j] - b[band] * y[j]) : (out[j] + a[band] * x[j]) + b[band] * y[j];

@ZhouXY-PKU ZhouXY-PKU Oct 22, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What can I say?

@Growl1234 Growl1234 Oct 22, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly I don't like this either, but clang-format choose what it thinks proper :(

@Growl1234 Growl1234 Oct 22, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is due to

abacus-develop/.clang-format

Line 12 in 75debc2

BreakBeforeBinaryOperators: All

Comment thread source/source_hsolver/kernels/bpcg_kernel_op.cpp Outdated
psi_iter + (nbase + m) * dim,
psi_m_norm);
if (psi_norm) {
ModuleBase::vector_div_constant_op<T, base_device::DEVICE_CPU>()(dim,

@ZhouXY-PKU ZhouXY-PKU Oct 22, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not pretty enough...

Comment thread source/source_hsolver/diago_scalapack.cpp
return std::make_pair(info, std::vector<int>{});
} else if (info < 0) {
}
else if (info < 0)

@ZhouXY-PKU ZhouXY-PKU Oct 22, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too many lines.

@Growl1234 Growl1234 Oct 22, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing style to LLVM will avoid such addition, but that was not accepted and then dropped in my first precommit PR.

Comment thread source/source_hsolver/linear_bicgstab.cpp Outdated
else
{
work_.dot_pair(ld_, dim_, active_, residual, residual, work_.data(shadow_slot), residual, norm_.data(), rho_.data());
work_.dot_pair(ld_,

@ZhouXY-PKU ZhouXY-PKU Oct 22, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too many lines.

Comment thread source/source_hsolver/orthonormal_small.cpp Outdated
const Wide one(1);
const Wide zero(0);
ModuleBase::gemm_op<Wide, base_device::DEVICE_CPU>()('N', 'N', n, n, n, &one, a.data(), n, b.data(), n, &zero, result->data(), n);
ModuleBase::gemm_op<Wide, base_device::DEVICE_CPU>()('N',

@ZhouXY-PKU ZhouXY-PKU Oct 22, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What can I say?

@ZhouXY-PKU ZhouXY-PKU removed the The Absolute Zero Reduce the "entropy" of the code to 0 label Oct 22, 2026
ABACUS-PR-BOT
ABACUS-PR-BOT reviewed Oct 23, 2026
View reviewed changes

@ABACUS-PR-BOT ABACUS-PR-BOT left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking: Please replace the template placeholders with a brief formatting/include-order summary and the exact verification commands and results. If builds or runtime tests were not run, state that and why, and note why INPUT documentation is unchanged. This reformat does not by itself require new functional tests.

@Growl1234
Growl1234 force-pushed the precommit-3 branch 3 times, most recently from b19cb89 to 79b99a5 Compare October 30, 2026 09:47
ABACUS-PR-BOT
ABACUS-PR-BOT reviewed Oct 30, 2026
View reviewed changes

@ABACUS-PR-BOT ABACUS-PR-BOT left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Static review of 0852c8cc against 64463eb3 found no confirmed source correctness defect. No candidate formatter, build or runtime tests were run.

Comment thread .clang-format
Comment on lines 11 to +18
BinPackArguments: false
BinPackParameters: false

BreakBeforeBinaryOperators: All
BreakBeforeTernaryOperators: true

Cpp11BracedListStyle: true
FixNamespaceComments: true

# InsertBraces: true # only for clang-format version15.0.0 or later

# About include
IncludeBlocks: Regroup
IncludeIsMainRegex: '([-_](test|unittest))?$'
IncludeIsMainSourceRegex: ''

PackArguments:
BinPack: UseBreakAfter
BreakAfter: 3
PackParameters:
BinPack: UseBreakAfter
BreakAfter: 3

@ABACUS-PR-BOT ABACUS-PR-BOT Oct 30, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking: In the pinned clang-format 23.1.3, PackArguments and PackParameters override the two legacy BinPack* settings above. Please remove those ineffective aliases so the active three-item packing threshold is clear.

@ZhouXY-PKU ZhouXY-PKU closed this Oct 30, 2026
@ZhouXY-PKU ZhouXY-PKU reopened this Oct 30, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZhouXY-PKU ZhouXY-PKU ZhouXY-PKU left review comments
@ABACUS-PR-BOT ABACUS-PR-BOT ABACUS-PR-BOT left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Refactor Refactor ABACUS codes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Growl1234 @ZhouXY-PKU @ABACUS-PR-BOT