Repository navigation
Precommit: Format CMake files (Part II) - #8187
Conversation
|
Some conflicts need to be solved. Thanks. @Growl1234 |
7073217 to
4d472ed
Compare
4d472ed to
5c7be9d
Compare
|
@ABACUS-PR-BOT Please take a final review on this PR. |
ABACUS-PR-BOT
left a comment
There was a problem hiding this comment.
Final static review of 324c2ef94d19: I found no new semantic issue in the 97 reformatted CMake files or the AddTest formatter metadata. Ordered command/argument comparisons and git diff --check passed; no configure/build/runtime or CI verification was performed.
The existing conflict discussion remains relevant: merging current develop (370ba685e670) produces conflicts in the LCAO DFT+U and PW DFT+U test CMakeLists. Preserve its dftu_base_io_write.cpp additions when resolving them.
Non-blocking: the PR description still contains the empty template. Please record the exact formatter/check commands and observed results, and explain why runtime tests and INPUT-doc updates are unnecessary for this formatting change.
2252159 to
231d542
Compare
231d542 to
86b7a7d
Compare
ABACUS-PR-BOT
left a comment
There was a problem hiding this comment.
Static inspection of 86b7a7d7ff6d against 64463eb3d896 found no build-logic defect introduced by this contribution. The inline suggestion completes the formatter’s AddTest schema. No formatter, configure/build, runtime or CI verification was performed.
cf995d9 to
e7fdda3
Compare
|
Reopen when new format is ready. |
e7fdda3 to
5d2f858
Compare
|
Hi @mohanchen, this PR is ready to merge. |
ABACUS-PR-BOT
left a comment
There was a problem hiding this comment.
Static review of 5d2f8587 found no CMake command/argument changes and retained the current build registrations. One formatter cleanup remains below. No configure, build, runtime or CI verification was performed.
Reminder
AGENTS.mdanddocs/developers_guide/agent_governance.md.source/changes.Linked Issue
Fix #
Unit Tests and/or Case Tests for my changes
What's changed?
Governance Notes