Skip to content

Precommit: Format CMake files (Part II) - #8187

Merged
mohanchen merged 3 commits into
deepmodeling:developfrom
Growl1234:precommit-cmake
Nov 2, 2026
Merged

mohanchen merged 3 commits into
deepmodeling:developfrom
Growl1234:precommit-cmake

Conversation

@Growl1234

Copy link
Copy Markdown
Collaborator

Reminder

  • I have read AGENTS.md and docs/developers_guide/agent_governance.md.
  • I have linked an issue or explained why this PR does not need one.
  • I have added adequate unit tests and/or case tests, or explained why not.
  • I have listed the exact verification commands run and their results.
  • I have described user-visible behavior changes, including INPUT parameter changes.
  • I have explained core-module impact for ESolver, HSolver, ElecState, Hamilt, Operator, Psi, or other source/ changes.
  • I have requested any needed governance exception below.

Linked Issue

Fix #

Unit Tests and/or Case Tests for my changes

  • Commands run:
  • Result summary:
  • Checks not run, with reason:

What's changed?

  • Example: brief summary of the user-visible or developer-facing change.

Governance Notes

  • INPUT/docs changes:
  • Core module impact:
  • Exceptions requested:

@Growl1234 Growl1234 added Compile & CICD & Docs & Dependencies Issues related to compiling ABACUS The Absolute Zero Reduce the "entropy" of the code to 0 labels Oct 20, 2026
@mohanchen

Copy link
Copy Markdown
Collaborator

Some conflicts need to be solved. Thanks. @Growl1234

@Growl1234
Growl1234 force-pushed the precommit-cmake branch 2 times, most recently from 7073217 to 4d472ed Compare October 21, 2026 09:37
@Growl1234

Growl1234 commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator Author

I'd prefer to have #8161 reviewed first, as resolving conflicts there after this PR is merged would be non-trivial. Once #8161 is merged, I can simply rerun pre-commit on the latest upstream HEAD and resubmit the commit here.

Comment thread source/source_base/CMakeLists.txt Resolved
@Growl1234 Growl1234 changed the title Precommit: Prettify CMake files (Part II) Precommit: Format CMake files (Part II) Oct 22, 2026
@ZhouXY-PKU

Copy link
Copy Markdown
Collaborator

@ABACUS-PR-BOT Please take a final review on this PR.

@ZhouXY-PKU ZhouXY-PKU removed the The Absolute Zero Reduce the "entropy" of the code to 0 label Oct 22, 2026

@ABACUS-PR-BOT ABACUS-PR-BOT left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final static review of 324c2ef94d19: I found no new semantic issue in the 97 reformatted CMake files or the AddTest formatter metadata. Ordered command/argument comparisons and git diff --check passed; no configure/build/runtime or CI verification was performed.

The existing conflict discussion remains relevant: merging current develop (370ba685e670) produces conflicts in the LCAO DFT+U and PW DFT+U test CMakeLists. Preserve its dftu_base_io_write.cpp additions when resolving them.

Non-blocking: the PR description still contains the empty template. Please record the exact formatter/check commands and observed results, and explain why runtime tests and INPUT-doc updates are unnecessary for this formatting change.

@ABACUS-PR-BOT ABACUS-PR-BOT left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Static inspection of 86b7a7d7ff6d against 64463eb3d896 found no build-logic defect introduced by this contribution. The inline suggestion completes the formatter’s AddTest schema. No formatter, configure/build, runtime or CI verification was performed.

Comment thread cmake-format.yaml Resolved
@Growl1234
Growl1234 force-pushed the precommit-cmake branch 3 times, most recently from cf995d9 to e7fdda3 Compare October 31, 2026 13:02
@mohanchen

Copy link
Copy Markdown
Collaborator

Reopen when new format is ready.

@mohanchen mohanchen closed this Nov 1, 2026
@Growl1234 Growl1234 reopened this Nov 1, 2026
@Growl1234

Copy link
Copy Markdown
Collaborator Author

Hi @mohanchen, this PR is ready to merge.

@ABACUS-PR-BOT ABACUS-PR-BOT left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Static review of 5d2f8587 found no CMake command/argument changes and retained the current build registrations. One formatter cleanup remains below. No configure, build, runtime or CI verification was performed.

Comment thread source/source_base/CMakeLists.txt Resolved
@mohanchen
mohanchen merged commit 43242cb into deepmodeling:develop Nov 2, 2026
18 checks passed
@Growl1234
Growl1234 deleted the precommit-cmake branch November 2, 2026 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Compile & CICD & Docs & Dependencies Issues related to compiling ABACUS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants