Fix: Fix LibXC 7.x build after the XC gradient split - #7884
Open
AsTonyshment wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #7873,
Split some large files (fs_nonlocal_tools.cpp, onsite_proj.cpp, to_wannier90_lcao.cpp, etc.) into smaller ones, removed the indirectlibxc_abacus.hinclude fromxc_grad.cppwhile splitting the XC gradient implementation. However,XC_Functional::gradcorr()still uses the LibXC functional IDXC_GGA_C_LYP.With LibXC 7.1.2,
xc.hdoes not define functional IDs; they are provided byxc_funcs.h. Consequently, builds withENABLE_LIBXC=ONfail becauseXC_GGA_C_LYPis undefined.This PR conditionally includes
xc_funcs.hwhen__LIBXCis enabled. The change restores the missing direct dependency without altering runtime or numerical behavior.