Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
92c371b
Slim down Plus_U_Base interface in dftu_base.h
Aug 29, 2026
192abb3
Fix: include parallel_comm.h for BP_WORLD in hsolver tests
Aug 29, 2026
9eca4a9
Refactor DFT+U base: unify DFTU_BASE namespace and slim Plus_U_Base
Aug 29, 2026
90c5550
refactor(dftu): add YukawaScreening class skeleton (no behavior change)
Aug 30, 2026
e505d06
refactor(dftu): hold YukawaScreening in Plus_U_Base
Aug 30, 2026
8310580
refactor(dftu): switch call sites to YukawaScreening, drop dftu_yukawa.*
Aug 30, 2026
942ff6f
refactor(dftu): drop legacy Yukawa members from Plus_U_Base
Aug 30, 2026
db7ce6e
refactor(dftu): add OccupationMatrix skeleton (unused for now)
Aug 30, 2026
9796e38
refactor(dftu): Plus_U_Base holds an OccupationMatrix instance
Aug 30, 2026
43c8af0
Refactor: route DFT+U occupation-matrix writes through OccupationMatrix
Aug 30, 2026
d74c70b
Refactor: remove legacy DFT+U occupation-matrix members
Aug 30, 2026
6484eef
docs: record nested-vector member extraction pattern in AGENTS.md
Aug 30, 2026
eedb894
refactor: move OccupationMatrix from module_pwdft to source_estate
Aug 30, 2026
e1949aa
refactor: drop Plus_U_Base pure-forwarding occupation accessors
Aug 30, 2026
a91ab8c
fix: guard YukawaScreening::cal_slater_Fk body with __LCAO
Aug 30, 2026
c90489c
refactor(dftu): slim dftu_lcao.h and turn pot_uterm_HR into free func…
Aug 30, 2026
8f2d19a
refactor(dftu): sink occupation mixing to source_estate and drop forw…
Aug 30, 2026
816f302
refactor(dftu): turn Plus_U_Base PW occ path into DFTU_BASE free func…
Aug 30, 2026
8045f36
refactor(dftu): collapse cal_occ_mat_k/gamma signatures onto Plus_U&
Aug 30, 2026
4fd1529
refactor(dftu): split DFT+U force/stress into r-space NAO files and r…
Aug 30, 2026
666147b
increase the thr of stress from 11 to 12 in example 15_KP_HSE_SOC_symm
Aug 30, 2026
e8c2852
refactor(dftu): rename all dftu_lcao* files to dftu_nao* for NAO basi…
Aug 30, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions AGENTS.md
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,9 @@ rules. Read the complete governance document before making or reviewing changes:
- Member -> free function: inventory `this->` reads; pass as params (const
for config, ref for mutable state); move only when body is `this`-free;
keep thin wrapper; compile each step.
- Extract a base-class nested-vector member in three steps (hold + forward,
switch writers, delete legacy) so no commit mixes old-storage writes with
new-storage reads.

## Local Commands

Expand Down
6 changes: 3 additions & 3 deletions source/Makefile.Objects
Original file line number Diff line number Diff line change
Expand Up @@ -746,9 +746,9 @@ OBJS_SRCPW=h_ewald_pw.o\
setup_pwwfc.o\
update_cell_pw.o\
dftu_base.o\
dftu_output.o\
dftu_tools_pw.o\
dftu_cal_occ_pw.o\
dftu_base_io.o\
dftu_base_occ.o\
dftu_base_tools.o\
setup_dftu_pw.o\
deltaspin_pw.o\
force_pw.o\
Expand Down
2 changes: 1 addition & 1 deletion source/source_esolver/esolver_ks.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
#include "source_hamilt/module_xc/xc_functional.h"
#include "source_io/module_output/output_log.h" // use write_head
#include "source_estate/elecstate_print.h" // print_etot
#include "source_lcao/module_dftu/dftu_lcao.h" // mohan add 2025-11-07
#include "source_lcao/module_dftu/dftu_nao.h" // mohan add 2025-11-07
#include "source_hamilt/module_xc/general_exx_info.h" // for init_general_exx_info

namespace ModuleESolver
Expand Down
2 changes: 1 addition & 1 deletion source/source_esolver/esolver_ks.h
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
#include "source_hamilt/hamilt.h" // use Hamiltonian
#include "source_hamilt/hamilt_base.h" // use Hamiltonian base class
#include "source_hamilt/module_xc/general_exx_info.h" // ESolver owns General_Exx_Info value
#include "source_lcao/module_dftu/dftu_lcao.h" // mohan add 20251107
#include "source_lcao/module_dftu/dftu_nao.h" // mohan add 20251107
#include "source_pw/module_pwdft/vnl_pw.h"

namespace ModuleESolver
Expand Down
2 changes: 1 addition & 1 deletion source/source_esolver/esolver_ks_pw.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ void ESolver_KS_PW<T, Device>::iter_init(UnitCell& ucell, const int istep, const

// update local occupations for DFT+U
// should before lambda loop in DeltaSpin
pw::iter_init_dftu_pw(iter,
DFTU_BASE::iter_init_dftu_pw(iter,
istep,
this->dftu,
this->stp.template get_psi_t<T, Device>(),
Expand Down
2 changes: 1 addition & 1 deletion source/source_esolver/lcao_others.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
#include "source_lcao/hamilt_lcao.h"
#include "source_lcao/lcao_domain.h"
#include "source_lcao/module_deltaspin/spin_constrain.h"
#include "source_lcao/module_dftu/dftu_lcao.h"
#include "source_lcao/module_dftu/dftu_nao.h"
#include "source_lcao/module_operator_lcao/op_exx_lcao.h"
#include "source_lcao/module_operator_lcao/operator_lcao.h"

Expand Down
1 change: 1 addition & 0 deletions source/source_estate/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ list(APPEND objects
module_charge/symm_rhog.cpp
fp_energy.cpp
occupy.cpp
occ_matrix.cpp
param_update.cpp
setup_estate_pw.cpp
update_pot.cpp
Expand Down
2 changes: 1 addition & 1 deletion source/source_estate/module_charge/chgmixing.cpp
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#include "source_estate/module_charge/chgmixing.h"
#include "source_estate/update_pot.h"
#include "source_lcao/module_dftu/dftu_lcao.h"
#include "source_lcao/module_dftu/dftu_nao.h"
#include "source_lcao/module_deltaspin/spin_constrain.h"

void module_charge::chgmixing_ks(const int iter, // scf iteration number
Expand Down
Loading
Loading