[Deepin-Kernel-SIG] [linux 6.6.y] [Xlnid] net: xlnid: kcompat: Also probe for DEEPIN_KABI_CONST - #2080
Conversation
The kcompat generator probes the kernel tree for a const-qualified dev_uevent() method, accepting either a plain const or RHEL's RH_KABI_CONST annotation. On deepin kernels the equivalent annotation is DEEPIN_KABI_CONST, which the probe does not recognize. Extend the match expression with DEEPIN_KABI_CONST so the generator keeps producing correct results when it is re-run against a deepin kernel tree. Keep the RH_KABI_CONST branch: this SDK is cross-distro compatibility code and may still be built on RHEL kernels. The pre-generated kcompat_generated_defs.h does not need to be regenerated: upstream 6.6 dev_uevent() is already const-qualified, so the plain const branch already matches. Fixes: a1accf3 ("net: ethernet: xel: add XEL network driver support") Assisted-by: Kimi Code:K3 Signed-off-by: WangYuli <wangyl5933@chinaunicom.cn>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR updates the kcompat generator for the xlnid SDK so that its probe for a const-qualified dev_uevent() method also recognizes the DEEPIN_KABI_CONST annotation used by deepin kernels, while retaining compatibility with existing plain const and RH_KABI_CONST cases. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Pull request overview
Extends xlnid’s compatibility probe to recognize Deepin’s const-preserving kABI annotation.
Changes:
- Adds
DEEPIN_KABI_CONSTto thedev_uevent()match. - Retains plain
constand RHEL compatibility.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
The kcompat generator probes the kernel tree for a const-qualified dev_uevent() method, accepting either a plain const or RHEL's RH_KABI_CONST annotation. On deepin kernels the equivalent annotation is DEEPIN_KABI_CONST, which the probe does not recognize.
Extend the match expression with DEEPIN_KABI_CONST so the generator keeps producing correct results when it is re-run against a deepin kernel tree. Keep the RH_KABI_CONST branch: this SDK is cross-distro compatibility code and may still be built on RHEL kernels.
The pre-generated kcompat_generated_defs.h does not need to be regenerated: upstream 6.6 dev_uevent() is already const-qualified, so the plain const branch already matches.
Fixes: a1accf3 ("net: ethernet: xel: add XEL network driver support")
Assisted-by: Kimi Code:K3
Summary by Sourcery
Enhancements: