[Deepin-Kernel-SIG] [linux 6.18.y] ci: Add workflow to build loonggpu DKMS module against the kernel - #2076
Open
opsiff wants to merge 1 commit into
Open
Conversation
Build the loonggpu DKMS package on every push and pull request so that DRM/KAPI changes breaking the out-of-tree module build (e.g. the drm_buddy_* and drm_fb_helper_*_fbi renames) are caught early. The DKMS source is taken from the deepin package pool: the workflow fetches the directory index of the loonggpu-kernel-dkms pool, picks the newest loong64 deb and unpacks it, so DKMS package updates require no changes to this file. The kernel is cross-compiled the same way as in build-kernel-loong64.yml to provide headers and Module.symvers, then the DKMS module is built through its own Makefile entry point (with its conftest-based API detection), which is equivalent to the compile step of a dkms build. Assisted-by: kimi:Kimi-K3 Signed-off-by: Wentao Guan <guanwentao@uniontech.com>
Reviewer's GuideAdds a GitHub Actions workflow that cross-compiles the loongarch kernel and then builds the out-of-tree loonggpu DKMS module on every push, PR, and manual dispatch to detect DRM/KAPI incompatibilities early. Sequence diagram for the build-dkms-loonggpu CI workflowsequenceDiagram
actor Developer
participant GitHub
participant Runner
participant DeepinRepo
participant KernelTree
participant DKMS_Source
Developer->>GitHub: push / pull_request / workflow_dispatch
GitHub->>Runner: start build-dkms-loonggpu job
Runner->>GitHub: actions_checkout@v6 (path kernel)
GitHub-->>Runner: kernel source
Runner->>DeepinRepo: curl LOONGGPU_DKMS_POOL index
DeepinRepo-->>Runner: deb listing
Runner->>DeepinRepo: curl loonggpu-kernel-dkms_<version>_loong64.deb
DeepinRepo-->>Runner: DKMS deb
Runner->>DKMS_Source: dpkg-deb -x loonggpu-dkms.deb
Runner->>DKMS_Source: locate Makefile in usr/src/loonggpu-*
Runner->>KernelTree: make deepin_loongarch_desktop_defconfig
Runner->>KernelTree: make ARCH=loongarch CROSS_COMPILE=loongarch64-linux-gnu-
Runner->>DKMS_Source: make modules SYSSRC=kernel ARCH=loongarch CROSS_COMPILE=loongarch64-linux-gnu-
Runner->>Runner: rm -rf dkms_workdir
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The logic that fetches and selects the newest loonggpu-kernel-dkms deb from the package pool should defensively filter by architecture and expected filename pattern to avoid accidentally picking an unintended artifact if the index format changes.
- Consider factoring out the cross-compilation steps shared with build-kernel-loong64.yml into a reusable composite action or a shared job template to reduce duplication and keep kernel build configuration consistent across workflows.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The logic that fetches and selects the newest loonggpu-kernel-dkms deb from the package pool should defensively filter by architecture and expected filename pattern to avoid accidentally picking an unintended artifact if the index format changes.
- Consider factoring out the cross-compilation steps shared with build-kernel-loong64.yml into a reusable composite action or a shared job template to reduce duplication and keep kernel build configuration consistent across workflows.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Pull request overview
Adds CI validation for loonggpu DKMS compatibility with the LoongArch kernel.
Changes:
- Downloads and extracts the latest loonggpu DKMS package.
- Cross-compiles the kernel and builds the external module.
- Cleans temporary build files.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| on: | ||
| push: | ||
| pull_request: |
Comment on lines
+45
to
+48
| deb=$(curl -fsSL "$LOONGGPU_DKMS_POOL/" \ | ||
| | grep -oE 'loonggpu-kernel-dkms_[^"]*_loong64\.deb' \ | ||
| | sort -uV | tail -1) | ||
| [ -n "$deb" ] || { echo "no loonggpu-kernel-dkms deb found in $LOONGGPU_DKMS_POOL"; exit 1; } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build the loonggpu DKMS package on every push and pull request so that DRM/KAPI changes breaking the out-of-tree module build (e.g. the drm_buddy_* and drm_fb_helper_*_fbi renames) are caught early.
The DKMS source is taken from the deepin package pool: the workflow fetches the directory index of the loonggpu-kernel-dkms pool, picks the newest loong64 deb and unpacks it, so DKMS package updates require no changes to this file. The kernel is cross-compiled the same way as in build-kernel-loong64.yml to provide headers and Module.symvers, then the DKMS module is built through its own Makefile entry point (with its conftest-based API detection), which is equivalent to the compile step of a dkms build.
Assisted-by: kimi:Kimi-K3
Summary by Sourcery
CI: