Fix/audit review#87
Merged
Merged
Conversation
…atus code, provider detail, url and request id
F1: Activity-level tool-call loop detection (cross-message)
- Add ToolSequenceTracker: period 1-4 detection, canonical JSON fingerprint
- Share one tracker per runLoop (activity), detect ABABAB across messages
- 21 new tests covering all acceptance criteria
F3: Tool parameter JSON parsing safety (AI SDK v6)
- Fix repair callback to use failed.toolCall.input (not .args)
- Classify errors: unknown_tool / invalid_json / schema_mismatch
- Never repair write/edit content; explicit fail with bounded error message
- 19 new tests
F4: Right-click copy session ID (verify existing impl)
- Confirmed: clipboard?.writeText(props.session.id), en/zh i18n complete
F5: Subagent hard depth limit + unified child admission
- MAX_SUBAGENT_DEPTH=3 process-level constant, cannot be widened by config
- resolveSessionDepth: metadata + parentID chain, cycle detection, fail closed
- admitChildOrFail: unified boundary for normal/takeover/background/resume
- Fix canTask/canTodo: evaluate() replaces rule-presence check
- 29 new tests
F6: Session-scoped terminal cache + LRU eviction
- Replace directoryTerminalCache with ScopedKey{scope+dir+session} map
- Per-tab draft UUID key, atomic draft→session migration
- LRU max 5 non-current entries per workspace, eviction calls pty.remove
- invalidateScopeSnapshots on runtimeId change
- clearWorkspaceTerminals covers mounted + cached entries
- 12 new tests
F2: Startup telemetry baseline + health poll fix
- 7 structured telemetry events (sidecar_spawn, layer_build, health_wait,
renderer.initialization, provider.state_init, pty_create, websocket_ready)
- Remove fixed 100ms pre-sleep before first health poll; try immediately
Startup UX overhaul:
- Splash overlay stays until deepagent-code:app-ready fires (5s failsafe)
- app-ready gate: server.ready() + layoutReady() + pageReady() +
autoselecting resolved + firstSessionLoadDone
- App renders in background behind overlay (no circular dependency)
- sidebar.opened defaults to false; transition suppressed until layoutReady()
- terminal panel transition suppressed until layoutReady()
- SidebarPanel shows SessionSkeleton instead of blank during loading
- Bottom + side terminal: gate pty.create on runtimeId set (prevents
immediate 503 on cold start with persisted opened=true state)
- pty.create: 10s overall deadline prevents permanent 'starting...' hang
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Hey! Your PR title Please update it to start with one of:
Where See CONTRIBUTING.md for details. |
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #
Type of change
What does this PR do?
Please provide a description of the issue, the changes you made to fix it, and why they work. It is expected that you understand why your changes work and if you do not understand why at least say as much so a maintainer knows how much to value the PR.
If you paste a large clearly AI generated description here your PR may be IGNORED or CLOSED!
How did you verify your code works?
Screenshots / recordings
If this is a UI change, please include a screenshot or recording.
Checklist
If you do not follow this template your PR will be automatically rejected.