Skip to content

Clarify sprite allocation sizes and restore Ruby scanning #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
decoder-dev merged 3 commits into from
Oct 26, 2026
Merged

Clarify sprite allocation sizes and restore Ruby scanning #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
68ebcdc
Make sprite allocation dimensions explicitly wide
decoder-dev Oct 26, 2026
5629d71
Restore Ruby coverage in the CodeQL analysis matrix
decoder-dev Oct 26, 2026
5767396
Give Ruby scanning its own source scope
decoder-dev Oct 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/codeql/codeql-ruby.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
name: "BananaGram Ruby sources"

# The C/C++ configuration excludes unshipped codec tools, including the directory
# containing loudnorm.rb. Ruby needs its own scope so committed Ruby code remains scanned.
queries:
- uses: security-extended
4 changes: 3 additions & 1 deletion .github/workflows/codeql.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,8 @@ jobs:
build-mode: none
- language: python
build-mode: none
- language: ruby
build-mode: none
- language: swift
build-mode: autobuild
# CodeQL supports the following values keywords for 'language': 'actions', 'c-cpp', 'csharp', 'go', 'java-kotlin', 'javascript-typescript', 'python', 'ruby', 'rust', 'swift'
Expand All @@ -77,7 +79,7 @@ jobs:
with:
languages: ${{ matrix.language }}
build-mode: ${{ matrix.build-mode }}
config-file: ./.github/codeql/codeql-config.yml
config-file: ${{ matrix.language == 'ruby' && './.github/codeql/codeql-ruby.yml' || './.github/codeql/codeql-config.yml' }}
# If you wish to specify custom queries, you can do so here or in a config file.
# By default, queries listed here will override any specified in a config file.
# Prefix the list here with "+" to use these queries and those in the config file.
Expand Down
6 changes: 4 additions & 2 deletions third-party/subcodec/src/sprite_encode.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
#include "codec_app_def.h"
#include "codec_def.h"

#include <cstddef>
#include <cstdlib>
#include <cstring>
#include <cstdio>
Expand Down Expand Up @@ -257,8 +258,9 @@
int cwm = impl_->canvas_width_mbs;

// Split into color (left half) and alpha (right half)
std::vector<MacroblockData> color((size_t)hwm * hhm);
std::vector<MacroblockData> alpha_mbs((size_t)hwm * hhm);
const std::size_t macroblock_count = static_cast<std::size_t>(hwm) * static_cast<std::size_t>(hhm);
Comment thread
decoder-dev marked this conversation as resolved.
Dismissed
std::vector<MacroblockData> color(macroblock_count);
std::vector<MacroblockData> alpha_mbs(macroblock_count);

for (int mb_y = 0; mb_y < hhm; mb_y++) {
for (int mb_x = 0; mb_x < hwm; mb_x++) {
Expand Down
Loading