Repository navigation
Widen media arithmetic before conversion and bound defaults parsing - #64
Merged
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // Split into color (left half) and alpha (right half) | ||
| std::vector<MacroblockData> color(hwm * hhm); | ||
| std::vector<MacroblockData> alpha_mbs(hwm * hhm); | ||
| std::vector<MacroblockData> color((size_t)hwm * hhm); |
| std::vector<MacroblockData> color(hwm * hhm); | ||
| std::vector<MacroblockData> alpha_mbs(hwm * hhm); | ||
| std::vector<MacroblockData> color((size_t)hwm * hhm); | ||
| std::vector<MacroblockData> alpha_mbs((size_t)hwm * hhm); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promote media-size, stride, offset and accumulator operands before multiplication, rather than converting a potentially overflowing narrow result afterwards. Cover 499 reported expressions, including shared allocation macros. Keep the intentional FFmpeg float-dither rounding and provably bounded POSIX-time parser unchanged; document those and the coefficient-template/legacy-decoder findings separately.
Make the keyboard-defaults parser alternatives disjoint so malformed escaped strings cannot trigger exponential backtracking. Add a bounded regression for an unterminated 100,000-backslash input, plus CI for existing native codec and Watch-package regression suites.
Validated locally: FFmpeg, libwebp and JPEG XL core library builds; three exact-pixel lossless WebP encode/decode round trips; Clang checks for all changed Watch Opus/WebP source units, CompanionRenderer/OpenSubdiv units and native rlottie bitmap source; both selected parser regressions; Python compilation and git diff --check.
The full Subcodec suite needs Apple Silicon because the existing implementation includes ARM NEON unconditionally; Linux x86 cannot execute it. The added macOS CI runs all 25 existing suites and the Watch packages. CodeQL and Apple-platform checks are pending; keep this draft until they pass. No CodeQL rule is disabled.