Repository navigation
Fix CI: TelegramUIPreferences BUILD (no sdk_frameworks) - #4
Merged
Merged
Conversation
Remove invalid sdk_frameworks (objc_library-only). Security links via import Security. Also upload IPA artifacts only on successful builds. Co-authored-by: D3C0Y <decoder-dev@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
swift_librarydoes not acceptsdk_frameworks— that attribute is forobjc_library. The Archive Keychain helper alreadyimport Security, which is enough for linking.Also: upload IPA artifacts only when the build succeeds (avoids failing the job twice).
Unblocks the PrivateMusic-style
xcode-27IPA CI /v12.9.2release.