Repository navigation
Fix ubuntu-latest Actions build by enabling Linux backend for eframe/winit - #1
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-authored-by: dddevid <141579210+dddevid@users.noreply.github.com>
|
@coderabbitai review |
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Regenerate Cargo.lock from the exact manifest to remove unintended glow dependencies.
Review effort: Lite
Findings: None
What changed in this PR
This PR enables eframe’s X11 backend for Ubuntu builds and updates the dependency lockfile.
Changes:
- Adds the
x11feature toeframe. - Updates
Cargo.lock. - Lockfile currently includes unintended
glowdependencies and should be regenerated.
| File | Summary |
|---|---|
Cargo.toml |
Enables the eframe X11 backend. |
Cargo.lock |
Records dependency resolution, but includes an unintended glow renderer dependency. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Build for ubuntu-latestfailed in GitHub Actions becausewinitcompiled without any Linux platform backend wheneframedefaults were disabled. This PR enables an explicit Linux backend so Ubuntu builds can compile consistently.Dependency feature correction
eframefeatures inCargo.tomlto include Linux windowing support (x11) alongside existingwgpu/default_fonts.default-features = falseintact; only add the missing platform feature.Lockfile alignment
Cargo.lockto capture the dependency graph introduced by the neweframefeature set.