Skip to content

Fix ubuntu-latest Actions build by enabling Linux backend for eframe/winit - #1

Merged
dddevid merged 2 commits into
masterfrom
copilot/fix-github-actions-build-ubuntu-latest
Sep 27, 2026
Merged

dddevid merged 2 commits into
masterfrom
copilot/fix-github-actions-build-ubuntu-latest

Conversation

Copilot AI commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor

Build for ubuntu-latest failed in GitHub Actions because winit compiled without any Linux platform backend when eframe defaults were disabled. This PR enables an explicit Linux backend so Ubuntu builds can compile consistently.

  • Dependency feature correction

    • Update eframe features in Cargo.toml to include Linux windowing support (x11) alongside existing wgpu/default_fonts.
    • Keep default-features = false intact; only add the missing platform feature.
  • Lockfile alignment

    • Regenerate Cargo.lock to capture the dependency graph introduced by the new eframe feature set.
# Cargo.toml
eframe = { version = "0.29.0", default-features = false, features = ["default_fonts", "wgpu", "x11"] }

@coderabbitai

coderabbitai Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: d6f7d651-4177-44a1-964c-c11d6aa54041

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Co-authored-by: dddevid <141579210+dddevid@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix failing GitHub Actions job Build for ubuntu-latest Fix ubuntu-latest Actions build by enabling Linux backend for eframe/winit Sep 27, 2026
Copilot AI requested a review from dddevid September 27, 2026 15:48
@dddevid

dddevid commented Sep 27, 2026

Copy link
Copy Markdown
Owner

@coderabbitai review

@dddevid
dddevid marked this pull request as ready for review September 27, 2026 15:49
Copilot AI lite review requested due to automatic review settings September 27, 2026 15:49
@dddevid
dddevid merged commit 74b0767 into master Sep 27, 2026
2 of 6 checks passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Regenerate Cargo.lock from the exact manifest to remove unintended glow dependencies.

Review effort: Lite
Findings: None

What changed in this PR

This PR enables eframe’s X11 backend for Ubuntu builds and updates the dependency lockfile.

Changes:

  • Adds the x11 feature to eframe.
  • Updates Cargo.lock.
  • Lockfile currently includes unintended glow dependencies and should be regenerated.
File Summary
Cargo.toml Enables the eframe X11 backend.
Cargo.lock Records dependency resolution, but includes an unintended glow renderer dependency.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants