Repository navigation
test(canopen): witness reset heartbeat chain completion - #484
Conversation
PR SummaryLow Risk Overview The test drops 100 ms Reviewed by Cursor Bugbot for commit 329247f. Bugbot is set up for automated code reviews on this repo. Configure here. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
What does this change?
The CANopen application-reset heartbeat regression used two 100 ms sleeps and host-time RawCan confirmation deadlines while its producer used a manual clock. Use a separate VirtualClock confirmation actor and positively witness that the due producer tick creates a new heartbeat-chain task which remains pending behind the held boot-up echo. After releasing all three expected echoes, await that exact task and verify the actor's chain identity remains unchanged.
All boot-up/state/tick ordering, exact frame-count and payload assertions remain. Confirmation and producer budgets are unchanged. No production code or public API changes.
Refs #362. The remaining SDO block-server timing fixtures still need their batch-completion audit.
Type of change
docs/test/refactor/chore/ci— no releaseValidation
The focused regression passes. Three real source mutations were runtime-red and restored: restore host-time RawCan binding, bypass heartbeat chaining, and omit the producer's reset-cycle restart. Runner:
/private/tmp/cankit-362-reset-confirm-mutations.py.Full local gates: 3043 net10 tests with coverage, net48 compilation, CI build, formatting, nine verified packages, 50 engineering tests and traceability. Cobertura parsed all 444 classes/nested types; production diff is empty, with no changed executable missing/partial entries.
Checklist
-p:CI=true, test (net10.0),dotnet format --verify-no-changes, and pack +eng/verify-packages.pyall pass locally