Skip to content

test(j1939): clock retry confirmation during echo grace #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dborgards merged 1 commit into from
Oct 27, 2026
Merged

test(j1939): clock retry confirmation during echo grace #482

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions tests/CanKit.Pro.Tests/TestCases/J1939/J1939NodeTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -770,7 +770,8 @@ public async Task A_Retry_During_Claim_Echo_Grace_Is_Not_Stolen_By_The_Late_Echo
{
using var clock = new VirtualClock();
using var bus = ControllableBus.DeferredEchoCapable(NewSession());
using var raw = new CanBusService(bus);
var confirmationActor = clock.NewActor();
using var raw = new ClockedCanBusService(bus, confirmationActor);
using var scripted = new ScriptedClaimBus(raw, ScriptedClaimBus.Script.HoldFirstClaim);
var actor = clock.NewActor();
var announce = TimeSpan.FromMilliseconds(80);
Expand All @@ -788,10 +789,18 @@ public async Task A_Retry_During_Claim_Echo_Grace_Is_Not_Stolen_By_The_Late_Echo
Func<Task> failed = () => first.WithTimeout(ShortTimeout);
await failed.Should().ThrowAsync<J1939NodeException>();

// Start the retry inside the predecessor's grace, so that grace can expire while
// its real one-second confirmation deadline is still in the future.
var halfGrace = TimeSpan.FromTicks(J1939NodeImpl.ClaimEchoGrace.Ticks / 2);
await clock.WaitUntilTimerArmedAsync(actor, J1939NodeImpl.ClaimEchoGrace, ShortTimeout);
await clock.AdvanceAsync(halfGrace);

var retry = node.ClaimAddressAsync(0x11);
await bus.DeferredEchoes.WaitForEnqueuedAsync(1, ShortTimeout);
await clock.WaitUntilTimerArmedAsync(actor, J1939NodeImpl.ClaimEchoGrace, ShortTimeout);
await clock.AdvanceAsync(J1939NodeImpl.ClaimEchoGrace);
await clock.WaitUntilTimerArmedAsync(confirmationActor, TimeSpan.FromSeconds(1), ShortTimeout);
await clock.WaitUntilTimerArmedAsync(actor, halfGrace, ShortTimeout);
await clock.AdvanceAsync(halfGrace);
await clock.WaitUntilTimerArmedAsync(confirmationActor, halfGrace, ShortTimeout);

await DrainObservedAsync(node, bus, AddressClaim(sourceAddress: 0x11, nameBytes));
bus.DeferredEchoes.ReleaseAll().Should().Be(1);
Expand Down
Loading