[dborgards]

What does this change?

Nine J1939-TP DeferredEcho test methods (eleven cases) used a virtual protocol clock while RawCan confirmation deadlines still ran on host time. Give each fixture a separate confirmation actor owned and advanced by its VirtualClock, and positively witness the first real one-second confirmation timer before releasing the echo. Existing CTS-hold, cancellation, stale-continuation and payload assertions remain intact; all confirmation and protocol budgets are unchanged.

Update the CodeQL triage record after the full main scan confirmed that #480 also fixed the previously retained #742 ownership recommendation, leaving 18 documented recommendations without new alerts.

Refs #362. Remaining claim-grace and CANopen DeferredEcho fixtures still need a separate audit.

Type of change

• docs / test / refactor / chore / ci — no release

Validation

Two real source mutations failed at runtime and were restored: restoring the host-time RawCan binding removes the witnessed virtual confirmation timer; replacing T4 with T3 violates the existing phase assertion. Runner: /private/tmp/cankit-362-tp-confirm-mutations.py.

Full local gates: 3043 net10 tests with Cobertura, net48 compilation, CI build, formatting, nine verified packages, 50 engineering tests, and traceability. Cobertura covers 444 classes/nested types; no production executable lines changed, so changed-line missing/partial entries are empty. Production behavior and public API are unchanged.

Checklist

• Build with -p:CI=true, test (net10.0), dotnet format --verify-no-changes, and pack + eng/verify-packages.py all pass locally
• New behaviour is covered by a test (existing regression assertions plus positive confirmation-timer witnesses)
• The requirement or ADR this relates to is referenced (Tests: wall-clock-gated tests after #92 — the 2026-10-21 inventory #362)

[cursor]

PR Summary

Low Risk
Test and documentation updates only; no production API or runtime behavior changes.

Overview
J1939-TP DeferredEcho tests that already drove protocol timing with a VirtualClock now route TX confirmation deadlines through the same clock instead of host time. Each affected fixture adds a confirmation actor, wraps the bus in ClockedCanBusService, and WaitUntilTimerArmedAsync for the one-second confirmation timer before releasing held echoes. CTS-hold, BAM cancellation, and stale-continuation assertions are unchanged.

The CodeQL triage doc records alert #742 as resolved (moved from retained recommendations to Changes, with a 2026-10-27 verification note on main).

^{Reviewed by Cursor Bugbot for commit ca50499. Bugbot is set up for automated code reviews on this repo. Configure here.}

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-27T04:49:53.969015Z	ca50499	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!