Repository navigation
feat(canopen): monitor foreign SRDO and GFC captures passively - #459
Conversation
PR SummaryMedium Risk Overview
Reviewed by Cursor Bugbot for commit 6a1741f. Bugbot is set up for automated code reviews on this repo. Configure here. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0c3a32f. Configure here.

What does this change?
Closes #401. Analysis tools can continuously inspect SRDO pairs and GFCs through
ForeignSrdoMonitorwithout a local CANopen node, object-dictionary writes or any transmissions. Prepared immutable mappings and explicit observer SCT/SRVT retain configuration provenance; producer snapshot refresh periods and CRC defaults are never inferred as observer limits.The monitor evaluates capture-time order, inversion, format, length and deadlines independently per SRDO, returns immutable values and historical age, and discards current/pending data on faults. Bounded polling preserves captured timing despite delayed UI delivery. Subscription sequences/drop counters qualify gaps separately, with fresh-pair recovery and sticky incomplete trace quality. Each valid or malformed GFC candidate remains a distinct timestamped bus event without sender or safe-state attribution. Configuration replacement, startup, mid-pair joins after gaps or timing failures, recovery, timing insufficiency and ownership/disposal are documented in the package guide and FR-CO-061.
Type of change
feat— new behaviour (minor release)fix/perf— bug or performance fix (patch release)docs/test/refactor/chore/ci— no release!in the title, plus aBREAKING CHANGE:footer explaining the migration)Checklist
-p:CI=true, test (net10.0),dotnet format --verify-no-changes, and pack +eng/verify-packages.pyall pass locallyValidation also includes net48 compilation, generated API approval, requirements traceability and engineering checks. Controlled-clock cases cover delayed delivery, interleaved traffic, deadline boundaries/ties, startup/recovery, replacement, loss sequences/counters and saturation/wrap, GFC format/repetitions, immutability, ownership and zero transmissions. Fresh Cobertura entries for every new type have no missing lines or partial branches. Source mutations for inversion, capture timing, cross-gap pairing, GFC format, producer observer limits, SRVT expiry, accidental transmission and rejoin classification/history each produced failing assertions, then were restored.