Repository navigation
ci: pin SDK version to bypass broken download redirect - #457
Conversation
PR SummaryLow Risk Overview Floating Reviewed by Cursor Bugbot for commit 7ef8a54. Bugbot is set up for automated code reviews on this repo. Configure here. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
What does this change?
CI stopped in
setup-dotnetbefore any build: the floating10.0.xrequest followed aka.ms todotnetorigin.blob.core.windows.net, which returned HTTP 409 (Public access is not permitted on this storage account). All four failing jobs on #455 failed again after one retry.All eight setup steps in CI, CodeQL, Docs and Release now request the same SDK 10.0.403 by exact version. The pinned installer's exact-version path bypasses aka.ms and downloads from
builds.dotnet.microsoft.com, which serves the same archive successfully. The SDK selected by the original floating request was already 10.0.403; this changes the resolution/download path, not the selected version. Action SHAs and the developer SDK policy inglobal.jsonare unchanged.Closes #456. Unblocks #455 once this fix is merged and incorporated there. The maintainer explicitly authorized this second concurrent authored PR as an exception to the usual one-PR rule.
Type of change
feat— new behaviour (minor release)fix/perf— bug or performance fix (patch release)docs/test/refactor/chore/ci— no releaseChecklist
-p:CI=true, test (net10.0),dotnet format --verify-no-changes, and pack +eng/verify-packages.pyall pass locallyValidation
builds.dotnet.microsoft.com.git diff --checkpasses.Installer limitation
The pinned setup action separately attempts the latest LTS runtime before installing the requested SDK. That preliminary download can still warn about the broken redirect; upstream code deliberately treats this preliminary failure as nonfatal. The exact SDK install includes its runtime and must succeed. This PR's runner checks validate the complete action, including Windows; it does not publish a release.
Runner evidence
The
versionjob on this head installed SDK 10.0.403 directly frombuilds.dotnet.microsoft.comand passed. Its preliminary runtime install also succeeded: the aka.ms runtime redirect now points to the regular Microsoft host rather than the origin account. This external state differs from the two failed runs of #455, so its failed workflows have been retried once more while this pin remains under review.