Skip to content

docs(ci): document the Maintain bypass and preserve BREAKING label casing - #452

Merged
dborgards merged 1 commit into
mainfrom
docs/remaining-ci-findings-361
Oct 25, 2026
Merged

dborgards merged 1 commit into
mainfrom
docs/remaining-ci-findings-361

Conversation

@dborgards

Copy link
Copy Markdown
Owner

What does this change?

The release instructions described the main ruleset bypass as owner-specific. The live ruleset instead reports repositoryRoleDatabaseId: 2, repositoryRoleName: "maintain", bypassMode: ALWAYS. The release workflow comment and both instructions now identify that configured role and tell the operator to check the PAT identity against the active ruleset.

The label manifest now spells the existing major-version label BREAKING, matching the requested spelling already applied to the repository and issue #299. This keeps the next label synchronization from reverting its capitalization.

Refs #361 (B-2). The issue remains open for its other outstanding decisions; no permissions or ruleset settings are changed.

Type of change

  • feat — new behaviour (minor release)
  • fix / perf — bug or performance fix (patch release)
  • docs / test / refactor / chore / ci — no release
  • Breaking change

Checklist

  • Build with -p:CI=true, test (net10.0), dotnet format --verify-no-changes, and pack + eng/verify-packages.py all pass locally
  • Public API changes are documented with XML comments — no public API change
  • New behaviour is covered by a test — no runtime behaviour change
  • The requirement or ADR this relates to is referenced — Build/CI/docs: minor findings (B-2..B-16) from the 2026-10-21 deep review #361 B-2

Validation

  • Live GitHub REST ruleset read confirms RepositoryRole id 2; GraphQL resolves its name to maintain on this repository.
  • Both modified YAML files parse successfully; all 50 verification-script tests pass.
  • On the current base including fix(isotp): report the owned actor's shutdown timeout before unsubscribing #450: Release build has zero warnings/errors; full net10.0 suite 2881/2881 passed; formatting verification passed; fresh pack verified all 9 packages.
  • Documentation and configuration casing only; no modified executable library lines for patch coverage.

@cursor

cursor Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

PR Summary

Low Risk
Documentation and label manifest casing only; no workflow permissions, ruleset settings, or library behavior changes.

Overview
Aligns release documentation and workflow comments with how main is actually protected: RELEASE_TOKEN must come from an identity covered by the Maintain ruleset bypass (RepositoryRole id 2 in .github/rulesets/main.json), not a repo-owner-only bypass. Operators are told to verify the PAT identity against the live ruleset before releasing.

Renames the synced label manifest entry from breaking to BREAKING so label sync matches the repository spelling (e.g. issue #299) and does not revert capitalization on the next run.

Reviewed by Cursor Bugbot for commit b81a606. Bugbot is set up for automated code reviews on this repo. Configure here.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-25T10:20:14.915172Z b81a606 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@codecov

codecov Bot commented Oct 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@dborgards
dborgards merged commit 145b17d into main Oct 25, 2026
16 checks passed
@dborgards
dborgards deleted the docs/remaining-ci-findings-361 branch October 25, 2026 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant