Skip to content

test(canopen): the next transfer's SDO timeout is beyond any stall in the stale-outcome tests #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dborgards merged 2 commits into from
Oct 20, 2026
Merged

test(canopen): the next transfer's SDO timeout is beyond any stall in the stale-outcome tests #335

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1bddd9b
test(canopen): the next transfer's SDO timeout is beyond any stall in…
dborgards Oct 20, 2026
c718751
Merge branch 'main' into test/311-block-send-outcome
dborgards Oct 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions tests/CanKit.Pro.Tests/TestCases/CANopen/CanOpenSdoClientSendFailureTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -507,11 +507,16 @@ public async Task A_Send_Outcome_Of_A_Cancelled_Block_Transfer_Touches_Nothing(b
// The block initiate is still unconfirmed when the caller cancels. Its outcome, failed,
// arrives after the session is gone -- with no transfer to that server, or with the next
// one already running -- and must fail neither.
//
// Nobody answers server 0x11, so the only way the next transfer can end on its own is
// its SDO timeout. A loaded host once took the 30 s this test used to allow and the
// assertion below read that timeout as the stale outcome's doing (#311); the timeout is
// now beyond any stall, and the transfer is cancelled at the end regardless.
using var bus = ControllableBus.EchoCapable($"canopen-sdo-block-stale-{Guid.NewGuid():N}");
using var inner = new CanBusService(bus);
var service = new HeldConfirmationService(inner);
using var client = CanOpen.OpenNode(service, 0x7F,
new CanOpenNodeOptions { SdoTimeout = TimeSpan.FromSeconds(30) }, leaveOpen: true);
new CanOpenNodeOptions { SdoTimeout = TimeSpan.FromMinutes(10) }, leaveOpen: true);
var firstInitConfirmation = new TaskCompletionSource<TxConfirmation>();
var inits = 0;
service.Hold = frame =>
Expand Down Expand Up @@ -553,12 +558,12 @@ public async Task An_End_Acknowledgement_Outcome_After_Cancellation_Touches_Noth
{
// The upload is cancelled while its end acknowledgement is unconfirmed. That outcome
// then arrives with no transfer to the server, or with the next one running, and must
// complete neither.
// complete neither. The next transfer's SDO timeout is beyond any stall, as above (#311).
using var bus = ControllableBus.EchoCapable($"canopen-sdo-block-end-stale-{Guid.NewGuid():N}");
using var inner = new CanBusService(bus);
var service = new HeldConfirmationService(inner);
using var client = CanOpen.OpenNode(service, 0x7F,
new CanOpenNodeOptions { SdoTimeout = TimeSpan.FromSeconds(30) }, leaveOpen: true);
new CanOpenNodeOptions { SdoTimeout = TimeSpan.FromMinutes(10) }, leaveOpen: true);
var server = unchecked((int)CanOpenCobId.SdoTx(0x11));
var endAckConfirmation = new TaskCompletionSource<TxConfirmation>();
var endAckSent = new TaskCompletionSource<bool>(TaskCreationOptions.RunContinuationsAsynchronously);
Expand Down
Loading