Repository navigation
test(uds): the cancelled-after-its-window test runs on the virtual clock - #334
Conversation
The wall-clock version measured the host together with the client and came up 7 µs short of its 5 ms margin on a loaded runner (#312). On the clock, as its siblings O and Q since #171, a send is stamped later than its window's end and never earlier, so the gap from the cancellation to the next send is the client's and the bound needs no margin. With the window not noted again from the cancellation the test fails. Closes #312 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
PR SummaryLow Risk Overview The stub and UDS client share a Test-only — no library changes. Reviewed by Cursor Bugbot for commit 1ae2c12. Bugbot is set up for automated code reviews on this repo. Configure here. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
What does this change?
Closes #312.
UdsExpiredDeadlineTests.R_A_Suppressed_Send_Cancelled_After_Its_Provisional_Window_Still_Opens_Onemeasured the gap between the cancellation and the next send on the wall clock, with a 5 ms margin, and came up 7 µs short of it on a loaded runner. It now runs on the virtual clock like its siblings O and Q (#171): the stub, the client's deadlines and the stamps share the actor's clock, a send is stamped later than its window's end and never earlier, so the lower bound on the gap is the client's property and needs no margin. The claim the test makes is unchanged: the window is noted again from the cancellation, so the next send waits P2 from it.No source change.
Type of change
docs/test/refactor/chore/ci— no releaseChecklist
dotnet build CanKit.Pro.sln -c Release -p:CI=truesucceedsdotnet test CanKit.Pro.sln -c Release --framework net10.0passes (2423);dotnet format --verify-no-changesclean; pack +eng/verify-packages.py; traceability 0 new untraced🤖 Generated with Claude Code