Preserve literal passwords in PostgreSQL service files - #1631
Open
jackwalkerlabs wants to merge 1 commit into
Open
Preserve literal passwords in PostgreSQL service files#1631jackwalkerlabs wants to merge 1 commit into
jackwalkerlabs wants to merge 1 commit into
Conversation
Fixes dbcli#1512. Implemented and validated with Codex.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Service-file passwords such as
abc#def,a,b, and literal quoted values were changed by ConfigObj before connecting. Read the service file with interpolation and inline comments disabled so these values reach the connection unchanged. Leading pre-section comments remain supported, and parser errors retain their original file line numbers.Fixes #1512. As discussed there, quotes are now literal, matching libpq; the changelog calls out removing quotes previously used only to escape ConfigObj syntax.
Validation: six new regression cases fail on the original code; all seven pass with the change. Full suite against an isolated PostgreSQL 17 instance: 2,784 passed, 1 xfailed, 1 xpassed. Ruff lint and formatting hooks pass. Python 3.12 on macOS.
Implemented and tested using Codex under the submitting account's authorization.
Checklist