Repository navigation
security: bump astro 5.18.2 -> 7.3.3 in docs-site (critical RCE) - #371
Merged
Merged
Conversation
Closes the last critical advisory in this repo. eeth.dev is built from docs-site/, which had its own lockfile and was missed by an audit run at the repo root: GHSA-26w7-cxv4-gfx2 Astro: remote code execution through AVIF image optimization. Fixed in 7.2.8. Same bug class as the Next.js AVIF RCE patched in www and drain. Coherent version set (all published before this environment's registry cutoff, so `npm install` can actually resolve them): astro 5.18.2 -> 7.3.3 (>= 7.2.8, patched) @astrojs/starlight 0.32.6 -> 0.42.2 (peer: astro ^7.2.10) starlight-typedoc 0.21.5 -> 0.23.1 (peer: starlight >= 0.39.0) @astrojs/markdown-remark (new) 7.3.1 see below sharp 0.33.5 -> 0.35.4 `@astrojs/markdown-remark` has to be added explicitly: astro 7 dropped it in favour of @astrojs/markdown-satteri, but starlight still declares it as a peer, so nothing pulls it in and starlight fails to resolve without it. Two breaking changes had to be handled, which is why the dependabot PR for this bump never went green: 1. Starlight 0.33 changed `social` from an object to an array of link items -- migrated in astro.config.mjs. 2. typedoc now rejects `moduleResolution: node` (TS5107, node10 is deprecated) and could not find `process`, because tsconfig.docs.json put `types` at the top level where tsconfig ignores it. Moved `types` into compilerOptions and switched to `moduleResolution: bundler`. tsconfig.docs.json is referenced only by docs-site/astro.config.mjs, so the published library build is untouched. Verified against the live site rather than just a green build: - 80 pages build, exit 0 - homepage visible text identical to live eeth.dev, 1364 chars both - sitemap route sets identical, 79 routes each - docs-site npm audit: 0 vulnerabilities (was 1 critical) Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the last critical advisory in this repo.
eeth.devis built fromdocs-site/, which has its own lockfile — so annpm auditrun at the repo root misses it entirely. That's how this one stayed hidden.Same bug class as the Next.js AVIF RCE already patched in www and drain.
Versions
astro@astrojs/starlightastro ^7.2.10starlight-typedocstarlight >=0.39.0@astrojs/markdown-remarksharp@astrojs/markdown-remarkhas to be added explicitly: astro 7 dropped it in favour of@astrojs/markdown-satteri, but starlight still declares it a peer — so nothing pulls it in and starlight resolves toundefined.Two breaking changes — why dependabot's PR never went green
socialfrom an object to an array of link items. Migrated inastro.config.mjs.moduleResolution: nodenow errors (TS5107, node10 deprecated), andprocesswas unresolved becausetsconfig.docs.jsonputtypesat the top level, where tsconfig silently ignores it. MovedtypesintocompilerOptionsand switched tomoduleResolution: bundler.tsconfig.docs.jsonis referenced only bydocs-site/astro.config.mjs, so the published library build is untouched.Verification — against the live site, not just a green build
docs-sitenpm audit: 0 vulnerabilities (was 1 critical)🤖 Generated with Claude Code