control: add missing return after BADREQ in add/rm dep - #582
Merged
Conversation
davmac314
approved these changes
Sep 1, 2026
Owner
|
This change looks good, thanks.
You're welcome to do that if it needs further discussion, but note that in general you can get the same effect by introducing a stand-in dependency which depends on the relevant two dependencies. Eg if you want service A with a soft "dependency" on B, you can instead introduce C ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firstly, I have read and understand the CONTRIBUTING guide in full.
I'm currently building systemd-like nix API on top of dinit.
While implementing a forward-port of
SOFTdependency type to a current dinit version I had noticed that these return statements are missing.(I would like to discuss bringing
SOFTdependencies back in a discussion thread later).If a request with an unknown dependency type is issued, the dinit will respond with BADREQ+ACK and add the invalid dependency to the service's dependency list (which I think is a bug that should be fixed).