configure: write empty-but-set XXX_FOR_BUILD flags to mconfig - #578
Merged
mobin-2008 merged 1 commit intoAug 20, 2026
Merged
Conversation
davmac314
requested changes
Aug 20, 2026
Owner
There was a problem hiding this comment.
The change is fine, but can you please adjust the commit message slightly so that it reads clearly: hyphenate 'empty-but-set'.
configure: write empty-but-set XXX_FOR_BUILD flags to mconfig
Otherwise it reads like "write empty, but set XXX_FOR_BUILD flags to mconfig" which doesn't make sense.
Always write 'CXXFLAGS_FOR_BUILD', 'CPPFLAGS_FOR_BUILD' and 'LDFLAGS_FOR_BUILD' variables to mconfig if they are set. Addresses davmac314#552
mobin-2008
force-pushed
the
configure_XXX_FOR_BUILD_set_but_empty
branch
from
August 20, 2026 09:50
6749bd7 to
36688b0
Compare
mobin-2008
changed the title
davmac314
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Always write 'CXXFLAGS_FOR_BUILD', 'CPPFLAGS_FOR_BUILD' and 'LDFLAGS_FOR_BUILD' variables to mconfig if they are set.
Addresses #552
Tested with
./configure CXX="clang++" CXXFLAGS="--target=aarch64-linux-gnu -std=c++11" CXXFLAGS_FOR_BUILD=""