Allow setting sockstreambuf buffer size and max putback#3154
Open
kSkip wants to merge 2 commits into
Open
Conversation
kSkip
commented
Jul 17, 2026
Comment on lines
-101
to
+106
| setp(out_buffer, out_buffer + (out_buffer_size-1)); | ||
| setg(in_buffer+max_putback, | ||
| in_buffer+max_putback, | ||
| in_buffer+max_putback); | ||
| setp(out_buffer.get(), out_buffer.get() + (out_buffer_size-1)); |
Contributor
Author
There was a problem hiding this comment.
For here, should this be out_buffer + out_buffer_size? Because epptr is defined as "one past the end of the put area". If I understand this correctly, the effective buffer size will be 1 char smaller if we use out_buffer_size-1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would like to use the sockstreambuf with a larger buffer size, and think it would be nice to adjust the max put back as well. In addition, I also changed the buffer pointers to unique_ptr. I figured that was just pre-C++11 code.