Repository navigation
fix: Match VPC metrics toolbar to the portal - #908
Merged
Merged
Conversation
The VPC metrics step and refresh controls were hand-built with a plain border div and borderless select, so they looked different from the ALB metrics page. The region, instance and time pickers also bundled datum-ui 3.8, which predates the shared field trigger spec. Key changes: - build step and refresh from datum-ui ButtonGroup, ButtonGroupText and Button, with the same classes as the portal's metrics controls - take multi-select and picker from the host instead of bundling them - bump datum-ui to ^3.12.0
scotwells
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The step and refresh controls on the VPC metrics page were hand-built, so they looked different from the same controls on the ALB metrics page. They now use the shared datum-ui button group, with the same styling the portal uses for its own metrics controls. The region, instance and time range pickers now come from the portal instead of an older bundled copy, so they follow the current field styling too. The plugin's datum-ui dependency moves from 3.8 to 3.12.
Test plan