Repository navigation
ci: Run Test Alerts on every pull request, so it can be required - #650
Merged
Merged
Conversation
A required check that a paths filter skips stays pending, so the path-filtered workflow could not be required. The filter is removed: the alert-rule tests run on every pull request and every push to main. A run takes 11-13 s, against 5-7 minutes for the main CI workflow, so the filter saved little.
ecv
approved these changes
Nov 12, 2026
ecv
left a comment
ecv
left a comment
Contributor
There was a problem hiding this comment.
Approve.
Dropping the paths filter lets the alert tests become a required check, so a red alert test can no longer merge. All checks pass at this head, and test-alerts ran green on a PR that touches no alert file.
- The check reports as
test-alerts(the job name). That is the name to add torequired-ci.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #647, from its review. The Test Alerts workflow has a paths filter, so it cannot be a required check. GitHub says that checks of a workflow skipped by a paths filter "stay in a "Pending" state and block merging" (Handling skipped but required checks). So today a change to an alert can still merge with its test red. This PR lets the check be required.
Summary
main.Test plan
actionlintreports no problem.Merge danger
A two-way door: a revert restores the paths filter. The test steps do not change.
To the build team: after this merges, can
Test Alerts / test-alertsjoinrequired-ci?Related to #647