Skip to content

fix: Route shell session alerts to compute - #646

Merged
vvoytovych merged 1 commit into
mainfrom
fix/shell-session-alerts-catalog-service
Nov 12, 2026
Merged

vvoytovych merged 1 commit into
mainfrom
fix/shell-session-alerts-catalog-service

Conversation

@vvoytovych

Copy link
Copy Markdown
Contributor

The shell session alerts name a service and a team that the platform's service catalog does not list, so no route reaches a team and each of them lands in the catch-all channel, as several did in both environments over the last two weeks.

They now name compute and its team, build, as the catalog's row for compute names them, so their route reaches the build team's channel.

A new test reads the shipped rules, so it checks what deploys rather than a copy.

Changes

Change Effect
The six shell session alerts name compute as their service and build as their team
A new rule test checks that every shell session alert names compute and build, and that the availability page fires with them

Test plan

  • The new test fails on the previous service and team and passes on these
  • Routed through both environments' live alert trees, every shell session alert reaches the build team's channel, and the pages stay pages
  • After the release reaches production, the next shell session alert posts to the build team's channel
  • For a week after the release, no shell session alert reaches the catch-all channel in either environment

The shell-session alerts named their service compute-shell-sessions, which
the platform's service catalog does not list, so no route reached a team and
every one of them fell to the catch-all channel. They now name compute, the
catalog's service for this namespace, whose route reaches the build team's
channel, and team build, the catalog's team for compute.

Key changes:
- Each of the six shell-session alerts carries service: compute and
  team: build, as the catalog's row for compute names them
- A test extracts the shipped rules: every alert names compute and build,
  and the availability page fires with them
@vvoytovych vvoytovych self-assigned this Nov 12, 2026
@vvoytovych
vvoytovych requested a review from scotwells November 12, 2026 11:03
@vvoytovych
vvoytovych marked this pull request as ready for review November 12, 2026 11:12
@vvoytovych
vvoytovych requested a review from a team as a code owner November 12, 2026 11:12

@ecv ecv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve.

The six shell session alerts now reach the build team's channel instead of the catch-all, including the two pages.

  • Production's service catalog names datum_service: compute with team: build, and has no compute-shell-sessions row, which is why the old labels routed nowhere.
  • Only labels change, so no alert's expression changes.

Follow-ups:

  • No workflow, Taskfile or Makefile runs test/alerts/test-shell-sessions.sh, so the new test does not gate a PR. The same holds for test-reconcile-storm.sh. Wire both into CI, or the next label drift lands unchecked.

@vvoytovych
vvoytovych merged commit c8ce651 into main Nov 12, 2026
13 checks passed
@vvoytovych
vvoytovych deleted the fix/shell-session-alerts-catalog-service branch November 12, 2026 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants