Repository navigation
feat: add unikraft provider to shell agent - #643
Merged
Merged
Conversation
ecv
approved these changes
Nov 11, 2026
ecv
left a comment
ecv
left a comment
Contributor
There was a problem hiding this comment.
Approve.
Lets the shell agent serve unikernel instance pods as well as kata ones.
--managed-byis parsed as a comma-separated list, and the unikraft provider labels its instance podsmanaged-by: infra-provider-unikraft, so the new value matches.- Sessions still need the runtime class's
execcapability (unikraft-provider 276) and a cell withexecPolicyon; until then this only widens which pods the agent will accept.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shell agent is configured to only pick up pods managed by the kata provider. This PR adds
infra-provider-unikraftto--managed-byso unikernel instances are served too.Exec reaches a unikernel through the sandbox plugin, which is attached when the provider's
execPolicyis on.Depends on datum-cloud/unikraft-provider#275